From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BA3AC433DF for ; Mon, 15 Jun 2020 07:11:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FF9020707 for ; Mon, 15 Jun 2020 07:11:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728471AbgFOHJy (ORCPT ); Mon, 15 Jun 2020 03:09:54 -0400 Received: from verein.lst.de ([213.95.11.211]:59902 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728224AbgFOHJx (ORCPT ); Mon, 15 Jun 2020 03:09:53 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 5693568AFE; Mon, 15 Jun 2020 09:09:50 +0200 (CEST) Date: Mon, 15 Jun 2020 09:09:50 +0200 From: Christoph Hellwig To: Herbert Xu Cc: Alexander Viro , Sagi Grimberg , Christoph Hellwig , "David S. Miller" , Linux Kernel Mailing List , netdev@vger.kernel.org Subject: Re: [v3 PATCH] iov_iter: Move unnecessary inclusion of crypto/hash.h Message-ID: <20200615070950.GA21837@lst.de> References: <20200611074332.GA12274@gondor.apana.org.au> <20200611114911.GA17594@gondor.apana.org.au> <20200612065737.GA17176@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200612065737.GA17176@gondor.apana.org.au> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jun 12, 2020 at 04:57:37PM +1000, Herbert Xu wrote: > The header file linux/uio.h includes crypto/hash.h which pulls in > most of the Crypto API. Since linux/uio.h is used throughout the > kernel this means that every tiny bit of change to the Crypto API > causes the entire kernel to get rebuilt. > > This patch fixes this by moving it into lib/iov_iter.c instead > where it is actually used. > > This patch also fixes the ifdef to use CRYPTO_HASH instead of just > CRYPTO which does not guarantee the existence of ahash. > > Unfortunately a number of drivers were relying on linux/uio.h to > provide access to linux/slab.h. This patch adds inclusions of > linux/slab.h as detected by build failures. > > Also skbuff.h was relying on this to provide a declaration for > ahash_request. This patch adds a forward declaration instead. > > Signed-off-by: Herbert Xu Looks good: Reviewed-by: Christoph Hellwig