From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yehezkel Bernat <yehezkelshb@gmail.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-usb@vger.kernel.org,
Michael Jamet <michael.jamet@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Andreas Noever <andreas.noever@gmail.com>,
Lukas Wunner <lukas@wunner.de>,
netdev@vger.kernel.org
Subject: Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround
Date: Mon, 15 Jun 2020 15:51:12 +0200 [thread overview]
Message-ID: <20200615135112.GA1402792@kroah.com> (raw)
In-Reply-To: <CA+CmpXtpAaY+zKG-ofPNYHTChTiDtwCAnd8uYQSqyJ8hLE891Q@mail.gmail.com>
On Mon, Jun 15, 2020 at 04:45:22PM +0300, Yehezkel Bernat wrote:
> On Mon, Jun 15, 2020 at 4:02 PM Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> >
> > diff --git a/include/linux/thunderbolt.h b/include/linux/thunderbolt.h
> > index ff397c0d5c07..5db2b11ab085 100644
> > --- a/include/linux/thunderbolt.h
> > +++ b/include/linux/thunderbolt.h
> > @@ -504,8 +504,6 @@ struct tb_ring {
> > #define RING_FLAG_NO_SUSPEND BIT(0)
> > /* Configure the ring to be in frame mode */
> > #define RING_FLAG_FRAME BIT(1)
> > -/* Enable end-to-end flow control */
> > -#define RING_FLAG_E2E BIT(2)
> >
>
> Isn't it better to keep it (or mark it as reserved) so it'll not cause
> compatibility issues with older versions of the driver or with Windows?
How can you have "older versions of the driver"? All drivers are in the
kernel tree at the same time, you can't ever mix-and-match drivers and
kernels.
And how does Windows come into play here?
thanks,
greg k-h
next prev parent reply other threads:[~2020-06-15 13:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 13:01 [PATCH 0/4] thunderbolt: XDomain and NHI improvements Mika Westerberg
2020-06-15 13:01 ` [PATCH 1/4] thunderbolt: Build initial XDomain property block upon first connect Mika Westerberg
2020-06-15 13:01 ` [PATCH 2/4] thunderbolt: No need to warn if NHI hop_count != 12 or hop_count != 32 Mika Westerberg
2020-06-15 13:01 ` [PATCH 3/4] thunderbolt: NHI can use HopIDs 1-7 Mika Westerberg
2020-06-15 13:01 ` [PATCH 4/4] thunderbolt: Get rid of E2E workaround Mika Westerberg
2020-06-15 13:45 ` Yehezkel Bernat
2020-06-15 13:51 ` Greg Kroah-Hartman [this message]
2020-06-15 14:18 ` Yehezkel Bernat
2020-06-15 14:22 ` Mika Westerberg
2020-06-15 15:15 ` Yehezkel Bernat
2020-06-15 15:32 ` Mika Westerberg
2020-06-15 15:41 ` Yehezkel Bernat
2020-06-15 15:55 ` Mika Westerberg
2020-06-15 19:54 ` Yehezkel Bernat
2020-06-16 11:55 ` Mika Westerberg
2020-06-22 16:33 ` Mika Westerberg
2020-06-29 15:37 ` [PATCH 0/4] thunderbolt: XDomain and NHI improvements Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615135112.GA1402792@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.noever@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=yehezkelshb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).