From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23E94C433DF for ; Mon, 15 Jun 2020 13:51:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E86F9207DD for ; Mon, 15 Jun 2020 13:51:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592229095; bh=dm+rJYETE2p+THng6PDAKnvf2qsLyxCqzLjQQJTi9Ks=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=0hHRuV9XgiKS2eanpi7lMKFfOKuVWwy/pIRq/fUwkCzwhIwZKXn81/ecSABfSKFIg 5+jQFHP2f1W0pauWJr//fjgDckdpQA6B5Jk1czCbhU41dpGs2/aZAIpzJUjO58TjaK pB0oXBqhZUV6DdxPQUxOt7kIBUUxdVdZiaZsQgkA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730165AbgFONvd (ORCPT ); Mon, 15 Jun 2020 09:51:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:57340 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730077AbgFONv1 (ORCPT ); Mon, 15 Jun 2020 09:51:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3CDED2074D; Mon, 15 Jun 2020 13:51:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592229084; bh=dm+rJYETE2p+THng6PDAKnvf2qsLyxCqzLjQQJTi9Ks=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1nAFk1xg26wYsmRTfJ25DBRSGt/wsjfv9byn2ovJ4uMr7svCupdswYVGJGL52sShk 4hzSvz+pRvBrkJP01SaES5UWdT0fysKb2lG6Xbk9fc/cLXpyPWz/yJOuYSiRM83iXU hmyxVJTv9Sv8b4gKQrZuotl9qH/k4BT6cme6c/80= Date: Mon, 15 Jun 2020 15:51:12 +0200 From: Greg Kroah-Hartman To: Yehezkel Bernat Cc: Mika Westerberg , linux-usb@vger.kernel.org, Michael Jamet , "David S . Miller" , Jakub Kicinski , Andreas Noever , Lukas Wunner , netdev@vger.kernel.org Subject: Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround Message-ID: <20200615135112.GA1402792@kroah.com> References: <20200615130139.83854-1-mika.westerberg@linux.intel.com> <20200615130139.83854-5-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 15, 2020 at 04:45:22PM +0300, Yehezkel Bernat wrote: > On Mon, Jun 15, 2020 at 4:02 PM Mika Westerberg > wrote: > > > > diff --git a/include/linux/thunderbolt.h b/include/linux/thunderbolt.h > > index ff397c0d5c07..5db2b11ab085 100644 > > --- a/include/linux/thunderbolt.h > > +++ b/include/linux/thunderbolt.h > > @@ -504,8 +504,6 @@ struct tb_ring { > > #define RING_FLAG_NO_SUSPEND BIT(0) > > /* Configure the ring to be in frame mode */ > > #define RING_FLAG_FRAME BIT(1) > > -/* Enable end-to-end flow control */ > > -#define RING_FLAG_E2E BIT(2) > > > > Isn't it better to keep it (or mark it as reserved) so it'll not cause > compatibility issues with older versions of the driver or with Windows? How can you have "older versions of the driver"? All drivers are in the kernel tree at the same time, you can't ever mix-and-match drivers and kernels. And how does Windows come into play here? thanks, greg k-h