From: Andrew Lunn <andrew@lunn.ch>
To: Maxim Kochetkov <fido_max@inbox.ru>
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com,
hkallweit1@gmail.com, linux@armlinux.org.uk
Subject: Re: [PATCH 01/02] net: phy: marvell: Add Marvell 88E1340 support
Date: Tue, 16 Jun 2020 16:54:59 +0200 [thread overview]
Message-ID: <20200616145459.GA197468@lunn.ch> (raw)
In-Reply-To: <3fcbc447-877d-0e95-af39-86fc72a34e10@inbox.ru>
On Tue, Jun 16, 2020 at 10:01:11AM +0300, Maxim Kochetkov wrote:
> Add Marvell 88E1340 support
Hi Maxim
Are you sure this is an 88E1340, not a 88E1340S?
Marvells DSDT SDK has:
MAD_88E1340S = 0x1C, /* 88E1340S */
MAD_88E1340 = 0x1e, /* 88E1340/x0a */
MAD_88E1340M = 0x1f, /* 88E1340M/x0a */
> #define MARVELL_PHY_ID_88E1149R 0x01410e50
> #define MARVELL_PHY_ID_88E1240 0x01410e30
> #define MARVELL_PHY_ID_88E1318S 0x01410e90
> +#define MARVELL_PHY_ID_88E1340 0x01410dc0
> #define MARVELL_PHY_ID_88E1116R 0x01410e40
> #define MARVELL_PHY_ID_88E1510 0x01410dd0
> #define MARVELL_PHY_ID_88E1540 0x01410eb0
For 88E1340 i would expect the ID to be 0x01410de0
Andrew
next prev parent reply other threads:[~2020-06-16 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 7:01 [PATCH 01/02] net: phy: marvell: Add Marvell 88E1340 support Maxim Kochetkov
2020-06-16 14:54 ` Andrew Lunn [this message]
2020-06-17 4:49 ` Maxim Kochetkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616145459.GA197468@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=fido_max@inbox.ru \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).