From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D302C433E0 for ; Wed, 17 Jun 2020 16:19:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F021921532 for ; Wed, 17 Jun 2020 16:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592410750; bh=O63FTYo2bZgKRLcKaMC8kx5VHu/JZKpbfoq352EqP0s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=j56vZ14F1awA652JIHj0Fvwaz9ubvgLXKicBXIxO5U8hIzEbYmzmcc+o5xgb10fh3 7Svu33XjgAgIseXxhU/g6X7fCGYYz7gCqAX0otq4ZRcm6RAhiHEgjsx8SCVDZlgLde /2yVZGpqzEm8wa4c325pkceBUM2lTI4NPpeBRAPc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726845AbgFQQTI (ORCPT ); Wed, 17 Jun 2020 12:19:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:52110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726496AbgFQQTI (ORCPT ); Wed, 17 Jun 2020 12:19:08 -0400 Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A7D282080D; Wed, 17 Jun 2020 16:19:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592410747; bh=O63FTYo2bZgKRLcKaMC8kx5VHu/JZKpbfoq352EqP0s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UZN3DGoBhtnp6G77xh8Py+A01/wnE8EjrlxE8jO393KlWewhEOt0tdv4fdD3gQgk/ R2FMjNMr4yzmyl79JjrU2Us5gh3fNsUzAj3o34UevkzUcpnrC8agDyYTcEKDoD7CXy o+NmrvZQ4CQuoiryl8U72p8KTPne9+Eu60s86UDA= Date: Wed, 17 Jun 2020 09:19:05 -0700 From: Jakub Kicinski To: Xin Long Cc: netdev@vger.kernel.org, Steffen Klassert , Herbert Xu , "David S. Miller" , Sabrina Dubroca Subject: Re: [PATCH ipsec-next 02/10] tunnel4: add cb_handler to struct xfrm_tunnel Message-ID: <20200617091905.2b007939@kicinski-fedora-PC1C0HJN> In-Reply-To: <5a63a0c47cc71476786873cbd32db8db3c0f7d1e.1592328814.git.lucien.xin@gmail.com> References: <84bcb772ea1b68f3b150106b9db1825b65742cef.1592328814.git.lucien.xin@gmail.com> <5a63a0c47cc71476786873cbd32db8db3c0f7d1e.1592328814.git.lucien.xin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 17 Jun 2020 01:36:27 +0800 Xin Long wrote: > This patch is to register a callback function tunnel4_rcv_cb with > is_ipip set in a xfrm_input_afinfo object for tunnel4 and tunnel64. > > It will be called by xfrm_rcv_cb() from xfrm_input() when family > is AF_INET and proto is IPPROTO_IPIP or IPPROTO_IPV6. > > Signed-off-by: Xin Long Please make sure W=1 C=1 builds don't add new warnings: net/ipv4/tunnel4.c:118:14: warning: incorrect type in assignment (different address spaces) net/ipv4/tunnel4.c:118:14: expected struct xfrm_tunnel *head net/ipv4/tunnel4.c:118:14: got struct xfrm_tunnel [noderef] * net/ipv4/tunnel4.c:120:9: error: incompatible types in comparison expression (different address spaces): net/ipv4/tunnel4.c:120:9: struct xfrm_tunnel [noderef] * net/ipv4/tunnel4.c:120:9: struct xfrm_tunnel *