From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Willem de Bruijn <willemb@google.com>,
Antoine Tenart <antoine.tenart@bootlin.com>
Subject: Re: [PATCH net-next 4/5] net: tso: cache transport header length
Date: Wed, 17 Jun 2020 17:03:03 -0700 [thread overview]
Message-ID: <20200617170303.4fb4d0b1@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <20200617184819.49986-5-edumazet@google.com>
On Wed, 17 Jun 2020 11:48:18 -0700 Eric Dumazet wrote:
> Add tlen field into struct tso_t, and change tso_start()
> to return skb_transport_offset(skb) + tso->tlen
>
> This removes from callers the need to use tcp_hdrlen(skb) and
> will ease UDP segmentation offload addition.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c: In function otx2_sq_append_tso:
drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:631:6: warning: hdr_len is used uninitialized in this function [-Wuninitialized]
631 | if (otx2_dma_map_tso_skb(pfvf, sq, skb, first_sqe, hdr_len)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next prev parent reply other threads:[~2020-06-18 0:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 18:48 [PATCH net-next 0/5] net: tso: expand to UDP support Eric Dumazet
2020-06-17 18:48 ` [PATCH net-next 1/5] net: tso: double TSO_HEADER_SIZE value Eric Dumazet
2020-06-18 0:02 ` Jakub Kicinski
2020-06-18 0:14 ` Eric Dumazet
2020-06-17 18:48 ` [PATCH net-next 2/5] net: tso: shrink struct tso_t Eric Dumazet
2020-06-17 18:48 ` [PATCH net-next 3/5] net: tso: constify tso_count_descs() and friends Eric Dumazet
2020-06-17 18:48 ` [PATCH net-next 4/5] net: tso: cache transport header length Eric Dumazet
2020-06-18 0:03 ` Jakub Kicinski [this message]
2020-06-17 18:48 ` [PATCH net-next 5/5] net: tso: add UDP segmentation support Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617170303.4fb4d0b1@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox