From: David Miller <davem@davemloft.net>
To: yangyingliang@huawei.com
Cc: netdev@vger.kernel.org, weiyongjun1@huawei.com
Subject: Re: [PATCH net] net: fix memleak in register_netdevice()
Date: Thu, 18 Jun 2020 20:06:43 -0700 (PDT) [thread overview]
Message-ID: <20200618.200643.27869075586210896.davem@davemloft.net> (raw)
In-Reply-To: <20200616093921.2185939-1-yangyingliang@huawei.com>
From: Yang Yingliang <yangyingliang@huawei.com>
Date: Tue, 16 Jun 2020 09:39:21 +0000
> I got a memleak report when doing some fuzz test:
...
> If call_netdevice_notifiers() failed, then rollback_registered()
> calls netdev_unregister_kobject() which holds the kobject. The
> reference cannot be put because the netdev won't be add to todo
> list, so it will leads a memleak, we need put the reference to
> avoid memleak.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2020-06-19 3:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 9:39 [PATCH net] net: fix memleak in register_netdevice() Yang Yingliang
2020-06-19 3:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618.200643.27869075586210896.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox