From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A500C433DF for ; Thu, 18 Jun 2020 02:01:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35F12214DB for ; Thu, 18 Jun 2020 02:01:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387455AbgFRCBP (ORCPT ); Wed, 17 Jun 2020 22:01:15 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:45760 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732982AbgFRCBI (ORCPT ); Wed, 17 Jun 2020 22:01:08 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jljrR-0013W0-TW; Thu, 18 Jun 2020 04:01:01 +0200 Date: Thu, 18 Jun 2020 04:01:01 +0200 From: Andrew Lunn To: Dan Murphy Cc: f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net, robh@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next v7 1/6] dt-bindings: net: Add tx and rx internal delays Message-ID: <20200618020101.GJ249144@lunn.ch> References: <20200617182019.6790-1-dmurphy@ti.com> <20200617182019.6790-2-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200617182019.6790-2-dmurphy@ti.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jun 17, 2020 at 01:20:14PM -0500, Dan Murphy wrote: > tx-internal-delays and rx-internal-delays are a common setting for RGMII > capable devices. > > These properties are used when the phy-mode or phy-controller is set to > rgmii-id, rgmii-rxid or rgmii-txid. These modes indicate to the > controller that the PHY will add the internal delay for the connection. > > Signed-off-by: Dan Murphy > --- > .../devicetree/bindings/net/ethernet-phy.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > index 9b1f1147ca36..b2887476fe6a 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > @@ -162,6 +162,17 @@ properties: > description: > Specifies a reference to a node representing a SFP cage. > > + > + rx-internal-delay-ps: > + description: | > + RGMII Receive PHY Clock Delay defined in pico seconds. This is used for > + PHY's that have configurable RX internal delays. > + > + tx-internal-delay-ps: > + description: | > + RGMII Transmit PHY Clock Delay defined in pico seconds. This is used for > + PHY's that have configurable TX internal delays. > + So in a later patch you have: default: 2000 That seems to apply that these values only apply when the phy mode indicates a delay is needed. It would be good to document that here, when each of these properties will be used. Also, that they default to 2000 when not present. Andrew