Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: "David S . Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Willem de Bruijn <willemb@google.com>,
	Sunil Goutham <sgoutham@marvell.com>,
	Antoine Tenart <antoine.tenart@bootlin.com>
Subject: [PATCH v2 net-next 3/6] net: tso: shrink struct tso_t
Date: Wed, 17 Jun 2020 20:53:23 -0700	[thread overview]
Message-ID: <20200618035326.39686-4-edumazet@google.com> (raw)
In-Reply-To: <20200618035326.39686-1-edumazet@google.com>

size field can be an int, no need for size_t

Removes a 32bit hole on 64bit kernels.

And align fields for better readability.

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 include/net/tso.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/include/net/tso.h b/include/net/tso.h
index c33dd00c161f7a6aa65f586b0ceede46af2e8730..d9b0a14b2a57b388ae4518fc63497ffd600b8887 100644
--- a/include/net/tso.h
+++ b/include/net/tso.h
@@ -7,12 +7,12 @@
 #define TSO_HEADER_SIZE		256
 
 struct tso_t {
-	int next_frag_idx;
-	void *data;
-	size_t size;
-	u16 ip_id;
-	bool ipv6;
-	u32 tcp_seq;
+	int	next_frag_idx;
+	int	size;
+	void	*data;
+	u16	ip_id;
+	bool	ipv6;
+	u32	tcp_seq;
 };
 
 int tso_count_descs(struct sk_buff *skb);
-- 
2.27.0.290.gba653c62da-goog


  parent reply	other threads:[~2020-06-18  3:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18  3:53 [PATCH v2 net-next 0/6] net: tso: expand to UDP support Eric Dumazet
2020-06-18  3:53 ` [PATCH v2 net-next 1/6] octeontx2-af: change (struct qmem)->entry_sz from u8 to u16 Eric Dumazet
2020-06-18  3:53 ` [PATCH v2 net-next 2/6] net: tso: double TSO_HEADER_SIZE value Eric Dumazet
2020-06-18  3:53 ` Eric Dumazet [this message]
2020-06-18  3:53 ` [PATCH v2 net-next 4/6] net: tso: constify tso_count_descs() and friends Eric Dumazet
2020-06-18  3:53 ` [PATCH v2 net-next 5/6] net: tso: cache transport header length Eric Dumazet
2020-06-18  3:53 ` [PATCH v2 net-next 6/6] net: tso: add UDP segmentation support Eric Dumazet
2020-06-19  3:46 ` [PATCH v2 net-next 0/6] net: tso: expand to UDP support David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200618035326.39686-4-edumazet@google.com \
    --to=edumazet@google.com \
    --cc=antoine.tenart@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sgoutham@marvell.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox