From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97076C433DF for ; Thu, 18 Jun 2020 12:06:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 763B7207D8 for ; Thu, 18 Jun 2020 12:06:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="i3r8xzak" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729355AbgFRMG3 (ORCPT ); Thu, 18 Jun 2020 08:06:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728048AbgFRMGY (ORCPT ); Thu, 18 Jun 2020 08:06:24 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1187AC0613EE for ; Thu, 18 Jun 2020 05:06:23 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id 64so2680077pfv.11 for ; Thu, 18 Jun 2020 05:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KnZMcd7hAByohLFNqoZ+jn6S/xUHmJ274kiUVqsCRiY=; b=i3r8xzakfwZ3uk+CMdQ56vr7b6YalR5xVqKnNsXOUACwqn6g/kFD9NV2DtKAsfwJaV dTBC6UOcltvDhwyOleA9nXDGIpHOG2RlCrdWU15Ljr1IGgxp9QnrdR1DY0w5foaTbGfH 2quSvqHaIzhOkFQBInGA1Qq04L+fJpUrRRnKhuk34E2+hhPa3RFn1/kFZfxUTtvqUWOq YSZIcjsh2KErBcDAtrH01Ak3g7V8H3xn3tabJBhESZWrFZJFu1qqF5y7Ar4pHQL8gTJ8 roE5u9XlqcQxRP2KBd75xfWgYdqYVZdKr+71OZxiKcjPxRF1BcFDndGlXizFJEmaxt1n UW4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KnZMcd7hAByohLFNqoZ+jn6S/xUHmJ274kiUVqsCRiY=; b=PvsVPpb7u+TvPpzp8A/DAuL7YFJiOjl8YD5Mg+7yqRx59b/3DUpCfRd02hjkpd2zSM dHZpmNMfQtGBYUHjk6bsh7Ev2Wn2fTuRPL9acyF2cPSy/QL0/ZVfvH2/rastPW2y13Dz hqcYiqKzrRQQJXVM/w0j5g53EpUtR7BWznX2t7/zRM0K5CN/bsfMKlbx3XRaq/oqfPPA ivE3E6Rfw6xHN7IQ+UvM5XA6PMbqHu/pOhrfevrrYIl7SmkQl73me5UlRflZP3OhkIpH OVEEAXjHuTmJXVesl5Ch6roVFOWK9RAxIVCsJHhEzIfZhDkKISuZZn0F7jrZYARK6Hya w58g== X-Gm-Message-State: AOAM532zoXZElrg/TKeTp1RJoMlLMZTE7oVC2lvrk9jI6DzugdbHlHKZ LTqfjdnstfwvQIBW52f1Rx5c X-Google-Smtp-Source: ABdhPJy6Et0T3fLfK70E25pbBoRMbq0GcwLBqfDU7X9MU0HLviPALhHwAj1hlrzRqKkBMR3NCwhJ4A== X-Received: by 2002:a63:1007:: with SMTP id f7mr3016539pgl.147.1592481983117; Thu, 18 Jun 2020 05:06:23 -0700 (PDT) Received: from mani ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id i22sm2780776pfo.92.2020.06.18.05.06.20 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Jun 2020 05:06:22 -0700 (PDT) Date: Thu, 18 Jun 2020 17:36:15 +0530 From: Manivannan Sadhasivam To: Marc Kleine-Budde Cc: wg@grandegger.com, kernel@martin.sperl.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver Message-ID: <20200618120615.GA3949@mani> References: <20200610074442.10808-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On 0611, Marc Kleine-Budde wrote: > On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote: > > Hello, > > > > This series adds CAN network driver support for Microchip MCP25XXFD CAN > > Controller with MCP2517FD as the target controller version. This series is > > mostly inspired (or taken) from the previous iterations posted by Martin Sperl. > > I've trimmed down the parts which are not necessary for the initial version > > to ease review. Still the series is relatively huge but I hope to get some > > reviews (post -rcX ofc!). > > > > Link to the origial series posted by Martin: > > https://www.spinics.net/lists/devicetree/msg284462.html > > > > I've not changed the functionality much but done some considerable amount of > > cleanups and also preserved the authorship of Martin for all the patches he has > > posted earlier. This series has been tested on 96Boards RB3 platform by myself > > and Martin has tested the previous version on Rpi3 with external MCP2517FD > > controller. > > I initially started looking at Martin's driver and it was not using several > modern CAN driver infrastructures. I then posted some cleanup patches but Martin > was not working on the driver any more. Then I decided to rewrite the driver, > that is the one I'm hoping to mainline soon. > > Can you give it a try? > > https://github.com/marckleinebudde/linux/commits/v5.6-rpi/mcp25xxfd-20200607-41 > Tested this version on my board with MCP2518FD and it works fine. I'm okay with moving forward with your version and would like to contribute. Please let me know how we can move forward. Thanks, Mani > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Embedded Linux | https://www.pengutronix.de | > Vertretung West/Dortmund | Phone: +49-231-2826-924 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |