From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Helmut Grohne <helmut.grohne@intenta.de>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: macb: reject unsupported rgmii delays
Date: Thu, 18 Jun 2020 20:10:17 +0100 [thread overview]
Message-ID: <20200618191017.GI1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <3eb49188-fb74-99fe-a9d9-7e295d2eaa8b@gmail.com>
On Thu, Jun 18, 2020 at 12:02:13PM -0700, Florian Fainelli wrote:
> It should not, but that means that when you describe the fixed-link, the
> 'phy-mode' within the local fixed-link node is meant to describe how the
> other side is configured not how you are configured. For some reason I
> did not consider that to be intuitive when I sent out my response, but I
> suppose spelling it out would greatly help.
Right, so in the MAC-to-MAC setup that is being discussed in this
thread, the _local_ side MAC where phy-mode is specified should not
care which of the RGMII modes is specified, because the delays are
a function of "the other side" of the link.
So, the proposal that macb should limit itself to only accepting
"rgmii" in it's _local_ phy-mode property because the _local_ MAC
does not support delays is wrong.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-06-18 19:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 7:49 [PATCH] net: macb: reject unsupported rgmii delays Helmut Grohne
2020-06-17 9:24 ` Nicolas Ferre
2020-06-17 9:57 ` Vladimir Oltean
2020-06-17 11:15 ` Helmut Grohne
2020-06-17 10:55 ` Russell King - ARM Linux admin
2020-06-17 11:21 ` Helmut Grohne
2020-06-17 11:40 ` Russell King - ARM Linux admin
2020-06-17 11:52 ` Helmut Grohne
2020-06-17 12:08 ` Russell King - ARM Linux admin
2020-06-18 8:14 ` Helmut Grohne
2020-06-18 8:45 ` Russell King - ARM Linux admin
2020-06-18 9:05 ` Helmut Grohne
2020-06-18 10:01 ` Russell King - ARM Linux admin
2020-06-18 18:26 ` Florian Fainelli
2020-06-18 18:06 ` Florian Fainelli
2020-06-18 18:49 ` Russell King - ARM Linux admin
2020-06-18 19:02 ` Florian Fainelli
2020-06-18 19:10 ` Russell King - ARM Linux admin [this message]
2020-06-17 11:32 ` Vladimir Oltean
2020-06-17 11:34 ` Russell King - ARM Linux admin
2020-06-17 11:38 ` Vladimir Oltean
2020-06-17 11:57 ` Russell King - ARM Linux admin
2020-06-18 18:25 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618191017.GI1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=helmut.grohne@intenta.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).