Re: [PATCH net-next v8 2/5] net: phy: Add a helper to return the index for of the internal delay

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1526 bytes --]

Hi Dan,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Dan-Murphy/RGMII-Internal-delay-common-property/20200619-051238
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cb8e59cc87201af93dfbb6c3dccc8fcad72a09c2
config: i386-defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/net/phy/phy_device.c: In function 'phy_get_int_delay_property':
>> drivers/net/phy/phy_device.c:2678:1: error: expected ';' before '}' token
    2678 | }
         | ^

vim +2678 drivers/net/phy/phy_device.c

  2660	
  2661	#if IS_ENABLED(CONFIG_OF_MDIO)
  2662	static int phy_get_int_delay_property(struct device *dev, const char *name)
  2663	{
  2664		s32 int_delay;
  2665		int ret;
  2666	
  2667		ret = device_property_read_u32(dev, name, &int_delay);
  2668		if (ret)
  2669			return ret;
  2670	
  2671		return int_delay;
  2672	}
  2673	#else
  2674	static inline int phy_get_int_delay_property(struct device *dev,
  2675						     const char *name)
  2676	{
  2677		return -EINVAL
> 2678	}
  2679	#endif
  2680	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28707 bytes --]