netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dominique Martinet <asmadeus@codewreck.org>
To: Alexander Kapshuk <alexander.kapshuk@gmail.com>
Cc: lucho@ionkov.net, ericvh@gmail.com, davem@davemloft.net,
	kuba@kernel.org, v9fs-developer@lists.sourceforge.net,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/9p: Validate current->sighand in client.c
Date: Sun, 21 Jun 2020 10:45:13 +0200	[thread overview]
Message-ID: <20200621084512.GA720@nautica> (raw)
In-Reply-To: <20200620201456.14304-1-alexander.kapshuk@gmail.com>

Alexander Kapshuk wrote on Sat, Jun 20, 2020:
> Use (un)lock_task_sighand instead of spin_lock_irqsave and
> spin_unlock_irqrestore to ensure current->sighand is a valid pointer as
> suggested in the email referenced below.

Thanks for v2! Patch itself looks good to me.

I always add another `Link:` tag to the last version of the patch at the
time of applying, so the message might be a bit confusing.
Feel free to keep the link to the previous discussion but I'd rather
just repeat a bit more of what we discussed (e.g. fix rcu not being
dereferenced cleanly by using the task helpers as suggested) rather than
just link to the thread

Sorry for nitpicking but I think commit messages are important and it's
better if they're understandable out of context, even if you give a link
for further details for curious readers, it helps being able to just
skim through git log.


Either way I'll include the patch in my test run today or tomorrow, had
promised it for a while...

Cheers,
-- 
Dominique

  reply	other threads:[~2020-06-21  8:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 18:33 [PATCH] net/9p: Fix sparse rcu warnings in client.c Alexander Kapshuk
2020-06-18 19:08 ` Dominique Martinet
2020-06-18 19:40   ` Alexander Kapshuk
2020-06-20 20:14   ` [PATCH] net/9p: Validate current->sighand " Alexander Kapshuk
2020-06-21  8:45     ` Dominique Martinet [this message]
2020-06-21 10:30       ` Alexander Kapshuk
2020-06-21 10:56         ` Dominique Martinet
2020-06-21 11:19           ` Alexander Kapshuk
2020-06-21 13:53       ` Alexander Kapshuk
2020-06-21 13:56         ` Dominique Martinet
2020-06-21 13:58           ` Alexander Kapshuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200621084512.GA720@nautica \
    --to=asmadeus@codewreck.org \
    --cc=alexander.kapshuk@gmail.com \
    --cc=davem@davemloft.net \
    --cc=ericvh@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucho@ionkov.net \
    --cc=netdev@vger.kernel.org \
    --cc=v9fs-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).