From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 743ADC433E0 for ; Sun, 21 Jun 2020 08:58:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 527CA2488F for ; Sun, 21 Jun 2020 08:58:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="l4HUFNhb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729590AbgFUI6B (ORCPT ); Sun, 21 Jun 2020 04:58:01 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:42979 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727119AbgFUI6B (ORCPT ); Sun, 21 Jun 2020 04:58:01 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id D01DC580558; Sun, 21 Jun 2020 04:57:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 21 Jun 2020 04:57:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=3K9ian o7tc8WbAJhJfY4t6jSmakbtH+Y8CHBQa0fNnw=; b=l4HUFNhb1v2HRiDTe23lB5 0XOyRciYS4gcBXy7LcMABmWTuWyJEbcAEGYWul8+/dyW4K28jxPE1klJ8dIfjXEm 5TaJ26ZtR73LbnveBHA2jNvQdNS1vo9qAfqnt0RNDQ3FWcTHAc+H5phcjtW55V21 oJ/ViCwKvaIqQEbEHYV8r4frGkiL7+MD0SGXpzEsXpMWCmshEOfLAVwDFH0XM/3c wVjJTebZJ6QsTWsMVlDAjGqGTerwa1VhYxJBaYH4o1i7/m5GRD5aHyGPVbu2tT8f B4GOaY7HhsKeForq9SRzvSu3heR+42fEwbAqu/0qDe7BzjEoErXGgGcOesnluIag == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudektddgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtth gvrhhnpedtffekkeefudffveegueejffejhfetgfeuuefgvedtieehudeuueekhfduheel teenucfkphepuddtledrieejrdekrdduvdelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepihguohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: from localhost (bzq-109-67-8-129.red.bezeqint.net [109.67.8.129]) by mail.messagingengine.com (Postfix) with ESMTPA id EC1F73066CFF; Sun, 21 Jun 2020 04:57:57 -0400 (EDT) Date: Sun, 21 Jun 2020 11:57:55 +0300 From: Ido Schimmel To: Vadym Kochan Cc: "David S. Miller" , Jakub Kicinski , Jiri Pirko , Ido Schimmel , Andrew Lunn , Oleksandr Mazur , Serhiy Boiko , Serhiy Pshyk , Volodymyr Mytnyk , Taras Chornyi , Andrii Savka , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mickey Rachamim Subject: Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices Message-ID: <20200621085755.GA477536@splinter> References: <20200528151245.7592-1-vadym.kochan@plvision.eu> <20200528151245.7592-2-vadym.kochan@plvision.eu> <20200530154801.GB1624759@splinter> <20200601105013.GB25323@plvision.eu> <20200603092358.GA1841966@splinter> <20200620125639.GA6911@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200620125639.GA6911@plvision.eu> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Jun 20, 2020 at 03:56:39PM +0300, Vadym Kochan wrote: > But it will look same as prestera_destroy_ports(), do you think > this is not a problem to have a same logic doubled ? No, error paths of init() usually share logic with fini(). The benefits of being consistent, always having init() followed by fini() and making sure they are symmetric, out-weigh the benefit of saving a few lines of code.