From: Andrew Lunn <andrew@lunn.ch>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
vladimir.oltean@nxp.com, claudiu.manoil@nxp.com,
alexandru.marginean@nxp.com, michael@walle.cc,
linux@armlinux.org.uk, f.fainelli@gmail.com, olteanv@gmail.com
Subject: Re: [PATCH net-next v2 0/5] net: phy: add Lynx PCS MDIO module
Date: Sun, 21 Jun 2020 17:56:38 +0200 [thread overview]
Message-ID: <20200621155638.GD338481@lunn.ch> (raw)
In-Reply-To: <20200621110005.23306-1-ioana.ciornei@nxp.com>
> Also, there is already a precedent of a PCS module (mdio-xpcs.c, the
> model of which I have followed) and without also changing that
> (which I am not comfortable doing) there is no point of changing
> this one.
I don't give this much value. You often need a couple of
implementation before you can see what the right structure should
be. And then you refactor. Jose is pretty active, and will probably
help refactor his driver if we ask him.
Andrew
prev parent reply other threads:[~2020-06-21 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 11:00 [PATCH net-next v2 0/5] net: phy: add Lynx PCS MDIO module Ioana Ciornei
2020-06-21 11:00 ` [PATCH net-next v2 1/5] net: phylink: add interface to configure clause 22 PCS PHY Ioana Ciornei
2020-06-21 11:00 ` [PATCH net-next v2 2/5] net: phylink: consider QSGMII interface mode in phylink_mii_c22_pcs_get_state Ioana Ciornei
2020-06-21 11:00 ` [PATCH net-next v2 3/5] net: mdiobus: add clause 45 mdiobus write accessor Ioana Ciornei
2020-06-21 11:00 ` [PATCH net-next v2 4/5] net: phy: add Lynx PCS MDIO module Ioana Ciornei
2020-06-21 11:00 ` [PATCH net-next v2 5/5] net: dsa: felix: use the Lynx PCS helpers Ioana Ciornei
2020-06-21 12:32 ` [PATCH net-next v2 0/5] net: phy: add Lynx PCS MDIO module Russell King - ARM Linux admin
2020-06-21 15:51 ` Andrew Lunn
2020-06-21 19:21 ` Ioana Ciornei
2020-06-21 20:46 ` Andrew Lunn
2020-06-21 15:56 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200621155638.GD338481@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandru.marginean@nxp.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).