From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54B28C433DF for ; Sun, 21 Jun 2020 15:56:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B0C32481B for ; Sun, 21 Jun 2020 15:56:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730421AbgFUP4k (ORCPT ); Sun, 21 Jun 2020 11:56:40 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50872 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729210AbgFUP4k (ORCPT ); Sun, 21 Jun 2020 11:56:40 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jn2Kk-001Xe3-OS; Sun, 21 Jun 2020 17:56:38 +0200 Date: Sun, 21 Jun 2020 17:56:38 +0200 From: Andrew Lunn To: Ioana Ciornei Cc: netdev@vger.kernel.org, davem@davemloft.net, vladimir.oltean@nxp.com, claudiu.manoil@nxp.com, alexandru.marginean@nxp.com, michael@walle.cc, linux@armlinux.org.uk, f.fainelli@gmail.com, olteanv@gmail.com Subject: Re: [PATCH net-next v2 0/5] net: phy: add Lynx PCS MDIO module Message-ID: <20200621155638.GD338481@lunn.ch> References: <20200621110005.23306-1-ioana.ciornei@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200621110005.23306-1-ioana.ciornei@nxp.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Also, there is already a precedent of a PCS module (mdio-xpcs.c, the > model of which I have followed) and without also changing that > (which I am not comfortable doing) there is no point of changing > this one. I don't give this much value. You often need a couple of implementation before you can see what the right structure should be. And then you refactor. Jose is pretty active, and will probably help refactor his driver if we ask him. Andrew