From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2154C433E0 for ; Mon, 22 Jun 2020 16:29:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A104320767 for ; Mon, 22 Jun 2020 16:29:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b1icpGRD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729522AbgFVQ3k (ORCPT ); Mon, 22 Jun 2020 12:29:40 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:47686 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729461AbgFVQ3j (ORCPT ); Mon, 22 Jun 2020 12:29:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592843377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FzLtoFQh/vN8wW8Srx1684Gpm2Q4p3etHyJcn3zpZ2o=; b=b1icpGRDlat9MMUtdOfCI9KIwjMdefSQjpiMrVDsFJ7Sf1+Uk3SuD4xq44z9xc7BhcPcTe r8ZFD2EsNuUf00jUJ5c+9Yc8QSxIk7olHIUul4E4MDUaCFRWeUBjQCmQEDl6olSx5GMYif X6CzhxL1dfZ7XTc2rCzJl1v16sVYAG0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-271-wGcBOPwNMcW-wQnTIMWRVg-1; Mon, 22 Jun 2020 12:29:32 -0400 X-MC-Unique: wGcBOPwNMcW-wQnTIMWRVg-1 Received: by mail-wr1-f72.google.com with SMTP id i10so7225272wrn.21 for ; Mon, 22 Jun 2020 09:29:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FzLtoFQh/vN8wW8Srx1684Gpm2Q4p3etHyJcn3zpZ2o=; b=W+O7gaJZBN9GzQ/xpznOktWv9IEDpjC/Gd2n7YSS6tjLeRrnwFW4Oaxw7oH6wJPT3x DR/dh4ZIRgAe9ijxRLPqx0QVZw24hBdiKTj+trUCAF2f6ufLJIjnWt1dnJ9q3w2OrKze C2xVyRAXVZixHHox137CZTpK/N+gLcpTaiwoJeP35YNWqvpfjYxXo+oF2alnS3Yl/M8Y IN+Safadz3yeoX7MFv8qSma/zbwap9GFipabcEBVLqTdRwyTskOGP6FtE4vQjuJWD0DT NjeKUlZBSMCUoRAOmBd9sfV3gmipvN9uLll6KZI7ivYK0OBPXpIPLdt4pYqJxXtv4ZLv tPew== X-Gm-Message-State: AOAM531hvNB71ZLq6lfkouyxrR+TB73h1/ZUCbfyMYHucshN9sooGKyS BuQ4dzflycV4pi5gKoQQudrpAPISynp2otayIu5ub3TGQuc6bTQ8eAsam21GEISS8+7utQvkjQX aCOZ5CitvoHMoBXNI X-Received: by 2002:a5d:470a:: with SMTP id y10mr7567521wrq.405.1592843371378; Mon, 22 Jun 2020 09:29:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTk56uu9uLED/XFyQTjpJIlBSf9Yjq+4mD8Dsvqij6CkK9q6rGvTmvotw6Je15SfiT50Mhig== X-Received: by 2002:a5d:470a:: with SMTP id y10mr7567504wrq.405.1592843371111; Mon, 22 Jun 2020 09:29:31 -0700 (PDT) Received: from redhat.com (bzq-79-178-18-124.red.bezeqint.net. [79.178.18.124]) by smtp.gmail.com with ESMTPSA id x205sm98811wmx.21.2020.06.22.09.29.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 09:29:30 -0700 (PDT) Date: Mon, 22 Jun 2020 12:29:28 -0400 From: "Michael S. Tsirkin" To: Eugenio Perez Martin Cc: Konrad Rzeszutek Wilk , linux-kernel@vger.kernel.org, kvm list , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, Jason Wang Subject: Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version Message-ID: <20200622122546-mutt-send-email-mst@kernel.org> References: <20200611113404.17810-1-mst@redhat.com> <20200611113404.17810-3-mst@redhat.com> <20200611152257.GA1798@char.us.oracle.com> <20200622114622-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 22, 2020 at 06:11:21PM +0200, Eugenio Perez Martin wrote: > On Mon, Jun 22, 2020 at 5:55 PM Michael S. Tsirkin wrote: > > > > On Fri, Jun 19, 2020 at 08:07:57PM +0200, Eugenio Perez Martin wrote: > > > On Mon, Jun 15, 2020 at 2:28 PM Eugenio Perez Martin > > > wrote: > > > > > > > > On Thu, Jun 11, 2020 at 5:22 PM Konrad Rzeszutek Wilk > > > > wrote: > > > > > > > > > > On Thu, Jun 11, 2020 at 07:34:19AM -0400, Michael S. Tsirkin wrote: > > > > > > As testing shows no performance change, switch to that now. > > > > > > > > > > What kind of testing? 100GiB? Low latency? > > > > > > > > > > > > > Hi Konrad. > > > > > > > > I tested this version of the patch: > > > > https://lkml.org/lkml/2019/10/13/42 > > > > > > > > It was tested for throughput with DPDK's testpmd (as described in > > > > http://doc.dpdk.org/guides/howto/virtio_user_as_exceptional_path.html) > > > > and kernel pktgen. No latency tests were performed by me. Maybe it is > > > > interesting to perform a latency test or just a different set of tests > > > > over a recent version. > > > > > > > > Thanks! > > > > > > I have repeated the tests with v9, and results are a little bit different: > > > * If I test opening it with testpmd, I see no change between versions > > > > > > OK that is testpmd on guest, right? And vhost-net on the host? > > > > Hi Michael. > > No, sorry, as described in > http://doc.dpdk.org/guides/howto/virtio_user_as_exceptional_path.html. > But I could add to test it in the guest too. > > These kinds of raw packets "bursts" do not show performance > differences, but I could test deeper if you think it would be worth > it. Oh ok, so this is without guest, with virtio-user. It might be worth checking dpdk within guest too just as another data point. > > > * If I forward packets between two vhost-net interfaces in the guest > > > using a linux bridge in the host: > > > > And here I guess you mean virtio-net in the guest kernel? > > Yes, sorry: Two virtio-net interfaces connected with a linux bridge in > the host. More precisely: > * Adding one of the interfaces to another namespace, assigning it an > IP, and starting netserver there. > * Assign another IP in the range manually to the other virtual net > interface, and start the desired test there. > > If you think it would be better to perform then differently please let me know. Not sure why you bother with namespaces since you said you are using L2 bridging. I guess it's unimportant. > > > > > - netperf UDP_STREAM shows a performance increase of 1.8, almost > > > doubling performance. This gets lower as frame size increase. > > > - rests of the test goes noticeably worse: UDP_RR goes from ~6347 > > > transactions/sec to 5830 > > > > OK so it seems plausible that we still have a bug where an interrupt > > is delayed. That is the main difference between pmd and virtio. > > Let's try disabling event index, and see what happens - that's > > the trickiest part of interrupts. > > > > Got it, will get back with the results. > > Thank you very much! > > > > > > > > - TCP_STREAM goes from ~10.7 gbps to ~7Gbps > > > - TCP_RR from 6223.64 transactions/sec to 5739.44 > >