From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B550C433ED for ; Mon, 22 Jun 2020 13:17:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31A0B206D7 for ; Mon, 22 Jun 2020 13:16:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728888AbgFVNQ6 convert rfc822-to-8bit (ORCPT ); Mon, 22 Jun 2020 09:16:58 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:38931 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728243AbgFVNQ6 (ORCPT ); Mon, 22 Jun 2020 09:16:58 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-476-mi0QBs-wNfqlYDGUsiP3LQ-1; Mon, 22 Jun 2020 09:16:54 -0400 X-MC-Unique: mi0QBs-wNfqlYDGUsiP3LQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 867CB1005512; Mon, 22 Jun 2020 13:16:53 +0000 (UTC) Received: from bistromath.localdomain (ovpn-112-149.ams2.redhat.com [10.36.112.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E2EEF100164C; Mon, 22 Jun 2020 13:16:51 +0000 (UTC) Date: Mon, 22 Jun 2020 15:16:50 +0200 From: Sabrina Dubroca To: Xin Long Cc: netdev@vger.kernel.org, Steffen Klassert , Herbert Xu , "David S. Miller" Subject: Re: [PATCH ipsec-next 02/10] tunnel4: add cb_handler to struct xfrm_tunnel Message-ID: <20200622131650.GD2557669@bistromath.localdomain> References: <5a63a0c47cc71476786873cbd32db8db3c0f7d1e.1592328814.git.lucien.xin@gmail.com> MIME-Version: 1.0 In-Reply-To: <5a63a0c47cc71476786873cbd32db8db3c0f7d1e.1592328814.git.lucien.xin@gmail.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: queasysnail.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 2020-06-17, 01:36:27 +0800, Xin Long wrote: > @@ -231,6 +255,7 @@ static int __init tunnel4_init(void) > goto err; > } > #endif > + xfrm_input_register_afinfo(&tunnel4_input_afinfo); This can fail. Shouldn't you handle that error? > return 0; > > err: -- Sabrina