* [PATCH net-next] net: thunderbolt: Add comment clarifying prtcstns flags
@ 2020-06-22 16:30 Mika Westerberg
2020-06-22 17:31 ` Yehezkel Bernat
2020-06-24 3:36 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Mika Westerberg @ 2020-06-22 16:30 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski
Cc: Michael Jamet, Yehezkel Bernat, Mika Westerberg, netdev
ThunderboltIP protocol currently has two flags from which we only
support and set match frags ID. The first flag is reserved for full E2E
flow control. Add a comment that clarifies them.
Suggested-by: Yehezkel Bernat <yehezkelshb@gmail.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/net/thunderbolt.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/thunderbolt.c b/drivers/net/thunderbolt.c
index a812726703a4..3160443ef3b9 100644
--- a/drivers/net/thunderbolt.c
+++ b/drivers/net/thunderbolt.c
@@ -1335,6 +1335,10 @@ static int __init tbnet_init(void)
tb_property_add_immediate(tbnet_dir, "prtcid", 1);
tb_property_add_immediate(tbnet_dir, "prtcvers", 1);
tb_property_add_immediate(tbnet_dir, "prtcrevs", 1);
+ /* Currently only announce support for match frags ID (bit 1). Bit 0
+ * is reserved for full E2E flow control which we do not support at
+ * the moment.
+ */
tb_property_add_immediate(tbnet_dir, "prtcstns",
TBNET_MATCH_FRAGS_ID);
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: thunderbolt: Add comment clarifying prtcstns flags
2020-06-22 16:30 [PATCH net-next] net: thunderbolt: Add comment clarifying prtcstns flags Mika Westerberg
@ 2020-06-22 17:31 ` Yehezkel Bernat
2020-06-24 3:36 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Yehezkel Bernat @ 2020-06-22 17:31 UTC (permalink / raw)
To: Mika Westerberg; +Cc: David S . Miller, Jakub Kicinski, Michael Jamet, netdev
On Mon, Jun 22, 2020 at 7:30 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> ThunderboltIP protocol currently has two flags from which we only
> support and set match frags ID. The first flag is reserved for full E2E
> flow control. Add a comment that clarifies them.
>
> Suggested-by: Yehezkel Bernat <yehezkelshb@gmail.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
>
Thanks!
Reviewed-by: Yehezkel Bernat <YehezkelShB@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: thunderbolt: Add comment clarifying prtcstns flags
2020-06-22 16:30 [PATCH net-next] net: thunderbolt: Add comment clarifying prtcstns flags Mika Westerberg
2020-06-22 17:31 ` Yehezkel Bernat
@ 2020-06-24 3:36 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-06-24 3:36 UTC (permalink / raw)
To: mika.westerberg; +Cc: kuba, michael.jamet, YehezkelShB, netdev
From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: Mon, 22 Jun 2020 19:30:22 +0300
> ThunderboltIP protocol currently has two flags from which we only
> support and set match frags ID. The first flag is reserved for full E2E
> flow control. Add a comment that clarifies them.
>
> Suggested-by: Yehezkel Bernat <yehezkelshb@gmail.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-24 3:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-22 16:30 [PATCH net-next] net: thunderbolt: Add comment clarifying prtcstns flags Mika Westerberg
2020-06-22 17:31 ` Yehezkel Bernat
2020-06-24 3:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).