From: Andrew Lunn <andrew@lunn.ch>
To: yunaixin03610@163.com
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-kernel@vger.kernel.org, wuguanping@huawei.com,
wangqindong@huawei.com
Subject: Re: [PATCH 4/5] Huawei BMA: Adding Huawei BMA driver: cdev_veth_drv
Date: Mon, 22 Jun 2020 20:22:30 +0200 [thread overview]
Message-ID: <20200622182230.GC405672@lunn.ch> (raw)
In-Reply-To: <20200622160311.1533-5-yunaixin03610@163.com>
On Tue, Jun 23, 2020 at 12:03:10AM +0800, yunaixin03610@163.com wrote:
> From: yunaixin <yunaixin03610@163.com>
>
> The BMA software is a system management software offered by Huawei. It supports the status monitoring, performance monitoring, and event monitoring of various components, including server CPUs, memory, hard disks, NICs, IB cards, PCIe cards, RAID controller cards, and optical modules.
>
> This cdev_veth_drv driver is one of the communication drivers used by BMA software. It depends on the host_edma_drv driver. It will create a char device once loaded, offering interfaces (open, close, read, write and poll) to BMA to send/receive RESTful messages between BMC software. When the message is longer than 1KB, it will be cut into packets of 1KB. The other side, BMC's cdev_veth driver, will assemble these packets back into original mesages.
Again, you never replied to my questions. In general, a char dev
interface to 'firmware' is not allowed. So i suggest you drop this
patch.
Andrew
next prev parent reply other threads:[~2020-06-22 18:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 16:03 [PATCH 0/5] Adding Huawei BMA drivers yunaixin03610
2020-06-22 16:03 ` [PATCH 1/5] Huawei BMA: Adding Huawei BMA driver: host_edma_drv yunaixin03610
2020-06-22 16:39 ` Randy Dunlap
2020-06-25 1:54 ` kernel test robot
2020-06-22 16:03 ` [PATCH 2/5] Huawei BMA: Adding Huawei BMA driver: host_cdev_drv yunaixin03610
2020-06-22 16:40 ` Randy Dunlap
2020-06-22 16:03 ` [PATCH 3/5] Huawei BMA: Adding Huawei BMA driver: host_veth_drv yunaixin03610
2020-06-22 16:41 ` Randy Dunlap
2020-06-22 18:38 ` Andrew Lunn
2020-06-22 20:27 ` kernel test robot
2020-06-22 16:03 ` [PATCH 4/5] Huawei BMA: Adding Huawei BMA driver: cdev_veth_drv yunaixin03610
2020-06-22 16:43 ` Randy Dunlap
2020-06-22 18:22 ` Andrew Lunn [this message]
2020-06-22 16:03 ` [PATCH 5/5] Huawei BMA: Adding Huawei BMA driver: host_kbox_drv yunaixin03610
2020-06-22 18:21 ` Andrew Lunn
2020-06-22 18:18 ` [PATCH 0/5] Adding Huawei BMA drivers Andrew Lunn
2020-06-22 19:38 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2020-06-16 2:05 [PATCH 4/5] Huawei BMA: Adding Huawei BMA driver: cdev_veth_drv yunaixin03610
2020-06-16 6:48 ` kernel test robot
2020-06-16 7:50 ` kernel test robot
2020-06-16 22:56 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622182230.GC405672@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wangqindong@huawei.com \
--cc=wuguanping@huawei.com \
--cc=yunaixin03610@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).