From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Jiri Pirko <jiri@mellanox.com>,
Johannes Berg <johannes@sipsolutions.net>,
David Miller <davem@davemloft.net>,
Petr Machata <petrm@mellanox.com>,
David Ahern <dsahern@gmail.com>, Netdev <netdev@vger.kernel.org>
Subject: Re: missing retval check of call_netdevice_notifiers in dev_change_net_namespace
Date: Tue, 23 Jun 2020 17:43:34 +1000 [thread overview]
Message-ID: <20200623074334.GA8574@gondor.apana.org.au> (raw)
In-Reply-To: <87imfjt2qu.fsf@x220.int.ebiederm.org>
On Mon, Jun 22, 2020 at 12:43:53PM -0500, Eric W. Biederman wrote:
>
> Adding Herbert Xu who added support for failing notifications in
> fcc5a03ac425 ("[NET]: Allow netdev REGISTER/CHANGENAME events to fail").
>
> He might have some insight but 2007 was a long time ago.
https://lists.openwall.net/netdev/2007/07/26/61
AFAICS this is still needed.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-06-23 7:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 8:58 missing retval check of call_netdevice_notifiers in dev_change_net_namespace Jason A. Donenfeld
2020-06-21 17:19 ` David Ahern
2020-06-22 9:24 ` Petr Machata
2020-06-22 17:43 ` Eric W. Biederman
2020-06-23 7:43 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623074334.GA8574@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=ebiederm@xmission.com \
--cc=jiri@mellanox.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).