From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53013C433DF for ; Tue, 23 Jun 2020 09:43:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 315C3206C3 for ; Tue, 23 Jun 2020 09:43:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="tf+1p30e" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732162AbgFWJm7 (ORCPT ); Tue, 23 Jun 2020 05:42:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731935AbgFWJm6 (ORCPT ); Tue, 23 Jun 2020 05:42:58 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A799C061573; Tue, 23 Jun 2020 02:42:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XwLVMpP6cYtFVBzdSro7PxdncqYRVnLMVLk9It8eSnA=; b=tf+1p30e2HRfibZvcGIgWdm64 euHfgRqyIfJz7Z14X4KDLhvTmozwXi1YqbRvoVo5SQkM7ggoaV/Y99/dRdEZJaIHh1OnwrAB5srvi I+Z+7oavGotEH8SpPoeiEwilvM+NIuGKNEj9LXSqjUbxmSAMmwY36mKHP1OwNJv6N0MgpyjPjnLHK 7id5NOZoBZntIPhqMq/OB8L+PQXSRAfl0F7MQ7v62+dbKk/6t+O8J/TRocgljM3EdK3rF0C/MZ+Ba qESqMzjrtcNDj6/wB9iNZwTzSWmBf55iojTnVK+9yICH6SxlweILkm7rh3VkkSvgCobKe9Cr5ZrC9 nmscJw74Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:59010) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnfSA-0001aO-Th; Tue, 23 Jun 2020 10:42:54 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jnfS8-0000vV-68; Tue, 23 Jun 2020 10:42:52 +0100 Date: Tue, 23 Jun 2020 10:42:52 +0100 From: Russell King - ARM Linux admin To: Bartosz Golaszewski Cc: Andrew Lunn , Alexandre Belloni , devicetree , Vladimir Oltean , Linux Kernel Mailing List , Fabien Parent , Iyappan Subramanian , Quan Nguyen , Frank Rowand , Florian Fainelli , Bartosz Golaszewski , Jakub Kicinski , Vivien Didelot , Tom Lendacky , Andrew Perepech , Stephane Le Provost , Keyur Chudgar , Jassi Brar , Claudiu Manoil , Mark Brown , "moderated list:ARM/Mediatek SoC..." , Matthias Brugger , Linux ARM , netdev , Ilias Apalodimas , Liam Girdwood , Rob Herring , Philipp Zabel , Pedro Tsai , "David S . Miller" , Heiner Kallweit Subject: Re: [PATCH 14/15] net: phy: add PHY regulator support Message-ID: <20200623094252.GS1551@shell.armlinux.org.uk> References: <20200622093744.13685-1-brgl@bgdev.pl> <20200622093744.13685-15-brgl@bgdev.pl> <20200622132921.GI1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jun 23, 2020 at 11:41:11AM +0200, Bartosz Golaszewski wrote: > pon., 22 cze 2020 o 15:29 Russell King - ARM Linux admin > napisał(a): > > > > [snip!] > > > > > This is likely to cause issues for some PHY drivers. Note that we have > > some PHY drivers which register a temperature sensor in the probe > > function, which means they can be accessed independently of the lifetime > > of the PHY bound to the network driver (which may only be while the > > network device is "up".) We certainly do not want hwmon failing just > > because the network device is down. > > > > That's kind of worked around for the reset stuff, because there are two > > layers to that: the mdio device layer reset support which knows nothing > > of the PHY binding state to the network driver, and the phylib reset > > support, but it is not nice. > > > > Regulators are reference counted so if the hwmon driver enables it > using mdio_device_power_on() it will stay on even after the PHY driver > calls phy_device_power_off(), right? Am I missing something? If that is true, you will need to audit the PHY drivers to add that. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!