From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E825DC433DF for ; Tue, 23 Jun 2020 14:42:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C06ED20774 for ; Tue, 23 Jun 2020 14:42:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jF4fFcmO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732837AbgFWOmR (ORCPT ); Tue, 23 Jun 2020 10:42:17 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:32045 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732738AbgFWOmQ (ORCPT ); Tue, 23 Jun 2020 10:42:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592923334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mPOfZFaF+bdCbm0ydM+kQRFRBQ8scE3A9xTZmb9+eHU=; b=jF4fFcmOWUeZzkHgzSRFZkOPwSpowDvuXwJPRVza+2NJA6QEYK14NPuc5zrfz6w6P6b4SJ BzoB/sRcTXoEA/E3E4qjhJruQOvEcdc3m/kEOhQoVBvWG4CP0QqEoHT1LWDvjrAqVXJFz0 B9PzmueCEHiEbWYh8+YrRn4a3K5BSyA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-6-l-ooj98CMdCGqT0rwualpA-1; Tue, 23 Jun 2020 10:42:12 -0400 X-MC-Unique: l-ooj98CMdCGqT0rwualpA-1 Received: by mail-wr1-f70.google.com with SMTP id e11so6455944wrs.2 for ; Tue, 23 Jun 2020 07:42:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=mPOfZFaF+bdCbm0ydM+kQRFRBQ8scE3A9xTZmb9+eHU=; b=eBgTQY8z6Trgz/U6ocjvJWPjz98qZ0mgcImRqpR1FWd9bDR9NBWIVvP5Tar294DJia SCwyDQeaQN9LFKOxsgwwIZRaWdSnGOeHXCjZRH6kwH6lVNR5hlvqWyDDphJIXTfjuH4A 79QagysvlaxCEskpVPvxfpKUkzCjt8YU//wybj67Ws6/2H405ENtckRSbE2sRygWxsoO q9LAhabaKDmCGRHVbXyPBY5gg2hSQDYtj5hwnRbJuelIBV3seqRsDbf4sYsITQT5ZVQU aTKsFZlfqcnx14eAGounEKLZkf63T9+o7+e+ENQkXlkCNhtuxbk7Ht7Ibe1TpwRssEaj Gf9Q== X-Gm-Message-State: AOAM5336Z+jqibTmus5Hc1uRJd4TGGkPNuKu2zPs8/PAjmlbMU2SqpHq bQ7H2CkPBSXO7JsVnWnWuzcVLFao0/Vqbh4O7TMvAkdo5EupqIX6dPFrGh1W/yxeCSF9PJAttTK 5cKQ6WmZL6bp85zXd X-Received: by 2002:adf:e285:: with SMTP id v5mr25169181wri.129.1592923330751; Tue, 23 Jun 2020 07:42:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmHWDOuDtiB37Ir1bpYYZm3cgpiWQYz+hwCXOOThQnShQNMF77cdnf/6yuMEyCU5MTi1D9bA== X-Received: by 2002:adf:e285:: with SMTP id v5mr25169152wri.129.1592923330463; Tue, 23 Jun 2020 07:42:10 -0700 (PDT) Received: from redhat.com (bzq-79-182-31-92.red.bezeqint.net. [79.182.31.92]) by smtp.gmail.com with ESMTPSA id n14sm521539wro.81.2020.06.23.07.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2020 07:42:09 -0700 (PDT) Date: Tue, 23 Jun 2020 10:42:06 -0400 From: "Michael S. Tsirkin" To: Eugenio =?iso-8859-1?Q?P=E9rez?= Cc: kvm list , Stefano Garzarella , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Stefan Hajnoczi , Jason Wang Subject: Re: [RFC v9 02/11] vhost: use batched get_vq_desc version Message-ID: <20200623103746-mutt-send-email-mst@kernel.org> References: <20200619182302.850-1-eperezma@redhat.com> <20200619182302.850-3-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200619182302.850-3-eperezma@redhat.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jun 19, 2020 at 08:22:53PM +0200, Eugenio Pérez wrote: > From: "Michael S. Tsirkin" > > As testing shows no performance change, switch to that now. > > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Eugenio Pérez > Link: https://lore.kernel.org/r/20200401183118.8334-3-eperezma@redhat.com > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Eugenio Pérez > --- > drivers/vhost/test.c | 2 +- > drivers/vhost/vhost.c | 314 ++++++++---------------------------------- > drivers/vhost/vhost.h | 7 +- > 3 files changed, 61 insertions(+), 262 deletions(-) > > diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c > index a09dedc79f68..650e69261557 100644 > --- a/drivers/vhost/test.c > +++ b/drivers/vhost/test.c > @@ -119,7 +119,7 @@ static int vhost_test_open(struct inode *inode, struct file *f) > dev = &n->dev; > vqs[VHOST_TEST_VQ] = &n->vqs[VHOST_TEST_VQ]; > n->vqs[VHOST_TEST_VQ].handle_kick = handle_vq_kick; > - vhost_dev_init(dev, vqs, VHOST_TEST_VQ_MAX, UIO_MAXIOV, > + vhost_dev_init(dev, vqs, VHOST_TEST_VQ_MAX, UIO_MAXIOV + 64, > VHOST_TEST_PKT_WEIGHT, VHOST_TEST_WEIGHT, true, NULL); > > f->private_data = n; > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index 2d784681b0fa..13021d6986eb 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -304,6 +304,7 @@ static void vhost_vq_reset(struct vhost_dev *dev, > { > vq->num = 1; > vq->ndescs = 0; > + vq->first_desc = 0; > vq->desc = NULL; > vq->avail = NULL; > vq->used = NULL; > @@ -372,6 +373,11 @@ static int vhost_worker(void *data) > return 0; > } > > +static int vhost_vq_num_batch_descs(struct vhost_virtqueue *vq) > +{ > + return vq->max_descs - UIO_MAXIOV; > +} > + > static void vhost_vq_free_iovecs(struct vhost_virtqueue *vq) > { > kfree(vq->descs); Batching is enabled if max_descs > UIO_MAXIOV. So this uses batching for test. But net is unchanged, so it is still not using the batched version. Is that right? I think a better subject would be "vhost/test: use batched get_vq_desc version". And that explains which testing it refers to: the one executed by vhost test. I think there was a separate patch to enable that for net separately, but it got lost - or did I miss it? -- MST