From: Yonghong Song <yhs@fb.com>
To: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, <kernel-team@fb.com>,
Martin KaFai Lau <kafai@fb.com>, Andrii Nakryiko <andriin@fb.com>
Subject: [PATCH bpf-next v5 11/15] selftests/bpf: refactor some net macros to bpf_tracing_net.h
Date: Tue, 23 Jun 2020 16:08:17 -0700 [thread overview]
Message-ID: <20200623230817.3988962-1-yhs@fb.com> (raw)
In-Reply-To: <20200623230803.3987674-1-yhs@fb.com>
Refactor bpf_iter_ipv6_route.c and bpf_iter_netlink.c
so net macros, originally from various include/linux header
files, are moved to a new header file
bpf_tracing_net.h. The goal is to improve reuse so
networking tracing programs do not need to
copy these macros every time they use them.
Acked-by: Andrii Nakryiko <andriin@fb.com>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: Yonghong Song <yhs@fb.com>
---
.../selftests/bpf/progs/bpf_iter_ipv6_route.c | 7 +------
.../selftests/bpf/progs/bpf_iter_netlink.c | 4 +---
.../selftests/bpf/progs/bpf_tracing_net.h | 16 ++++++++++++++++
3 files changed, 18 insertions(+), 9 deletions(-)
create mode 100644 tools/testing/selftests/bpf/progs/bpf_tracing_net.h
diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_ipv6_route.c b/tools/testing/selftests/bpf/progs/bpf_iter_ipv6_route.c
index 93a452d1d136..d58d9f1642b5 100644
--- a/tools/testing/selftests/bpf/progs/bpf_iter_ipv6_route.c
+++ b/tools/testing/selftests/bpf/progs/bpf_iter_ipv6_route.c
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/* Copyright (c) 2020 Facebook */
#include "bpf_iter.h"
+#include "bpf_tracing_net.h"
#include <bpf/bpf_helpers.h>
#include <bpf/bpf_tracing.h>
@@ -8,12 +9,6 @@ char _license[] SEC("license") = "GPL";
extern bool CONFIG_IPV6_SUBTREES __kconfig __weak;
-#define RTF_GATEWAY 0x0002
-#define IFNAMSIZ 16
-#define fib_nh_gw_family nh_common.nhc_gw_family
-#define fib_nh_gw6 nh_common.nhc_gw.ipv6
-#define fib_nh_dev nh_common.nhc_dev
-
SEC("iter/ipv6_route")
int dump_ipv6_route(struct bpf_iter__ipv6_route *ctx)
{
diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_netlink.c b/tools/testing/selftests/bpf/progs/bpf_iter_netlink.c
index fda5036fdf75..cec82a419800 100644
--- a/tools/testing/selftests/bpf/progs/bpf_iter_netlink.c
+++ b/tools/testing/selftests/bpf/progs/bpf_iter_netlink.c
@@ -1,14 +1,12 @@
// SPDX-License-Identifier: GPL-2.0
/* Copyright (c) 2020 Facebook */
#include "bpf_iter.h"
+#include "bpf_tracing_net.h"
#include <bpf/bpf_helpers.h>
#include <bpf/bpf_tracing.h>
char _license[] SEC("license") = "GPL";
-#define sk_rmem_alloc sk_backlog.rmem_alloc
-#define sk_refcnt __sk_common.skc_refcnt
-
static inline struct inode *SOCK_INODE(struct socket *socket)
{
return &container_of(socket, struct socket_alloc, socket)->vfs_inode;
diff --git a/tools/testing/selftests/bpf/progs/bpf_tracing_net.h b/tools/testing/selftests/bpf/progs/bpf_tracing_net.h
new file mode 100644
index 000000000000..1f38a1098727
--- /dev/null
+++ b/tools/testing/selftests/bpf/progs/bpf_tracing_net.h
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */
+#ifndef __BPF_TRACING_NET_H__
+#define __BPF_TRACING_NET_H__
+
+#define IFNAMSIZ 16
+
+#define RTF_GATEWAY 0x0002
+
+#define fib_nh_dev nh_common.nhc_dev
+#define fib_nh_gw_family nh_common.nhc_gw_family
+#define fib_nh_gw6 nh_common.nhc_gw.ipv6
+
+#define sk_rmem_alloc sk_backlog.rmem_alloc
+#define sk_refcnt __sk_common.skc_refcnt
+
+#endif
--
2.24.1
next prev parent reply other threads:[~2020-06-23 23:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 23:08 [PATCH bpf-next v5 00/15] implement bpf iterator for tcp and udp sockets Yonghong Song
2020-06-23 23:08 ` [PATCH bpf-next v5 01/15] net: bpf: add bpf_seq_afinfo in tcp_iter_state Yonghong Song
2020-06-23 23:08 ` [PATCH bpf-next v5 02/15] net: bpf: implement bpf iterator for tcp Yonghong Song
2020-06-23 23:08 ` [PATCH bpf-next v5 03/15] bpf: support 'X' in bpf_seq_printf() helper Yonghong Song
2020-06-23 23:08 ` [PATCH bpf-next v5 04/15] bpf: allow tracing programs to use bpf_jiffies64() helper Yonghong Song
2020-06-23 23:08 ` [PATCH bpf-next v5 05/15] bpf: add bpf_skc_to_tcp6_sock() helper Yonghong Song
2020-06-23 23:08 ` [PATCH bpf-next v5 06/15] bpf: add bpf_skc_to_{tcp,tcp_timewait,tcp_request}_sock() helpers Yonghong Song
2020-06-23 23:08 ` [PATCH bpf-next v5 07/15] net: bpf: add bpf_seq_afinfo in udp_iter_state Yonghong Song
2020-06-23 23:08 ` [PATCH bpf-next v5 08/15] net: bpf: implement bpf iterator for udp Yonghong Song
2020-06-23 23:08 ` [PATCH bpf-next v5 09/15] bpf: add bpf_skc_to_udp6_sock() helper Yonghong Song
2020-06-23 23:08 ` [PATCH bpf-next v5 10/15] selftests/bpf: move newer bpf_iter_* type redefining to a new header file Yonghong Song
2020-06-23 23:08 ` Yonghong Song [this message]
2020-06-23 23:08 ` [PATCH bpf-next v5 12/15] selftests/bpf: add more common macros to bpf_tracing_net.h Yonghong Song
2020-06-23 23:08 ` [PATCH bpf-next v5 13/15] selftests/bpf: implement sample tcp/tcp6 bpf_iter programs Yonghong Song
2020-06-23 23:08 ` [PATCH bpf-next v5 14/15] selftests/bpf: implement sample udp/udp6 " Yonghong Song
2020-06-23 23:08 ` [PATCH bpf-next v5 15/15] selftests/bpf: add tcp/udp iterator programs to selftests Yonghong Song
2020-06-25 1:45 ` [PATCH bpf-next v5 00/15] implement bpf iterator for tcp and udp sockets Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623230817.3988962-1-yhs@fb.com \
--to=yhs@fb.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).