From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31627C433DF for ; Wed, 24 Jun 2020 08:07:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E85420B1F for ; Wed, 24 Jun 2020 08:07:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dN7TtV+3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390286AbgFXIHM (ORCPT ); Wed, 24 Jun 2020 04:07:12 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:60271 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2389022AbgFXIHM (ORCPT ); Wed, 24 Jun 2020 04:07:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592986031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ss5NVTkBdepnWqRKDwI/TRxHk9OHYS3Y1jWbknW/W5k=; b=dN7TtV+3RorYxMpWC22zAJ4D2T+O8fhtGbAOGE1lRH07DlIer5dCnD2otfs+AleWBQztEA M0xuqX3dTNnPIM6/MpnTqobPYevx4Df/DwXUw70Iz8zma+xfeGp64V17nEgczN18IGKL/8 0Q8TvFoNW5Fcbrjgg3lPhrq7nuCyd1c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-59-6-8ItMA1OkWJSUYDmI6TrQ-1; Wed, 24 Jun 2020 04:07:07 -0400 X-MC-Unique: 6-8ItMA1OkWJSUYDmI6TrQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D55FA8015F7; Wed, 24 Jun 2020 08:07:05 +0000 (UTC) Received: from carbon (unknown [10.40.208.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id D933760F89; Wed, 24 Jun 2020 08:06:53 +0000 (UTC) Date: Wed, 24 Jun 2020 10:06:52 +0200 From: Jesper Dangaard Brouer To: Lorenzo Bianconi Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, toke@redhat.com, lorenzo.bianconi@redhat.com, dsahern@kernel.org, andrii.nakryiko@gmail.com, David Ahern , brouer@redhat.com Subject: Re: [PATCH v3 bpf-next 2/9] net: Refactor xdp_convert_buff_to_frame Message-ID: <20200624100652.0f57212f@carbon> In-Reply-To: <0f32f3dd1787f050b41ab1d32490b838544fe3e2.1592947694.git.lorenzo@kernel.org> References: <0f32f3dd1787f050b41ab1d32490b838544fe3e2.1592947694.git.lorenzo@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 23 Jun 2020 23:39:27 +0200 Lorenzo Bianconi wrote: > From: David Ahern > > Move the guts of xdp_convert_buff_to_frame to a new helper, > xdp_update_frame_from_buff so it can be reused removing code duplication > > Suggested-by: Jesper Dangaard Brouer > Co-developed-by: Lorenzo Bianconi > Signed-off-by: Lorenzo Bianconi > Signed-off-by: David Ahern Acked-by: Jesper Dangaard Brouer -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer