From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=xG3k=AG=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1
	autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 26835C433E0
	for <netdev@archiver.kernel.org>; Thu, 25 Jun 2020 10:09:18 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 0D824206B7
	for <netdev@archiver.kernel.org>; Thu, 25 Jun 2020 10:09:18 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2390873AbgFYKJR (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 25 Jun 2020 06:09:17 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34816 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2389646AbgFYKJO (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 25 Jun 2020 06:09:14 -0400
Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 426EAC061573
        for <netdev@vger.kernel.org>; Thu, 25 Jun 2020 03:09:13 -0700 (PDT)
Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92)
        (envelope-from <fw@strlen.de>)
        id 1joOog-0006FB-2A; Thu, 25 Jun 2020 12:09:10 +0200
Date:   Thu, 25 Jun 2020 12:09:10 +0200
From:   Florian Westphal <fw@strlen.de>
To:     Sabrina Dubroca <sd@queasysnail.net>
Cc:     Florian Westphal <fw@strlen.de>, steffen.klassert@secunet.com,
        netdev@vger.kernel.org
Subject: Re: [PATCH ipsec-next v2 2/6] xfrm: replay: get rid of duplicated
 notification code
Message-ID: <20200625100910.GY26990@breakpoint.cc>
References: <20200624080804.7480-1-fw@strlen.de>
 <20200624080804.7480-3-fw@strlen.de>
 <20200625070741.GA2939559@bistromath.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200625070741.GA2939559@bistromath.localdomain>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

Sabrina Dubroca <sd@queasysnail.net> wrote:
> >  	case XFRM_REPLAY_MODE_BMP:
> >  		xfrm_replay_notify_bmp(x, event);
> > -		return;
> > +		goto notify;
> >  	case XFRM_REPLAY_MODE_ESN:
> >  		xfrm_replay_notify_esn(x, event);
> > -		return;
> > +		goto notify;
> 
> These two functions have some early returns that skip the
> notification, but now the notification will be sent in all cases:

Right, I will rework this series.

Thanks for pointing this out.