From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 237E0C433DF for ; Thu, 25 Jun 2020 17:23:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2B4020789 for ; Thu, 25 Jun 2020 17:23:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593105831; bh=CA8sK1iaFslFSn8XGSDmoUdnBkprbim1itFO/LPNh/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=y/MJlEok7qScp1ioroVWzKNgJhHkHMWBq/wGLq1EksZtJNvoARaf6PEzC3rLHmxZx lkVPe0pBKmwpE3V7YYZpo+PKofW1LaL0pmwgP3cEZfaS1Rsamq+gmWBEPuN6Z69N1K 9E7XB7pOrHesazz/g4sZPCkHQKyUtQ2DIr1oNpiU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406692AbgFYRXr (ORCPT ); Thu, 25 Jun 2020 13:23:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:48104 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404378AbgFYRXr (ORCPT ); Thu, 25 Jun 2020 13:23:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57D4720773; Thu, 25 Jun 2020 17:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593105826; bh=CA8sK1iaFslFSn8XGSDmoUdnBkprbim1itFO/LPNh/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zvjAC9yYbAgnqLTGPS1P81nV2NWhnDq+aLq1948TpmmXlp9JIBddj6DSbePiKRdzP iy5BNoaAgBHoUFOgS0kGB3GkvEaZumFrUl7SwWZmL4RR43hRLyeYmKCl2GZYUuz4u5 kVEtEG49aDmjyQnuUopYz7ozKlvFsewDUnfTZTho= Date: Thu, 25 Jun 2020 19:23:42 +0200 From: Greg Kroah-Hartman To: Coiby Xu Cc: devel@driverdev.osuosl.org, "supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER" , open list , Manish Chopra , "open list:QLOGIC QLGE 10Gb ETHERNET DRIVER" Subject: Re: [PATCH 2/2] fix else after return or break Message-ID: <20200625172342.GA3965841@kroah.com> References: <20200625153614.63912-1-coiby.xu@gmail.com> <20200625153614.63912-3-coiby.xu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200625153614.63912-3-coiby.xu@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jun 25, 2020 at 11:36:14PM +0800, Coiby Xu wrote: > Signed-off-by: Coiby Xu > --- > drivers/staging/qlge/qlge_dbg.c | 23 ++++++++++------------- > drivers/staging/qlge/qlge_main.c | 8 ++++---- > drivers/staging/qlge/qlge_mpi.c | 4 ++-- > 3 files changed, 16 insertions(+), 19 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot