From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6FEEC433DF for ; Thu, 25 Jun 2020 17:53:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EBC2207E8 for ; Thu, 25 Jun 2020 17:53:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="JXnUiNef" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406934AbgFYRxp (ORCPT ); Thu, 25 Jun 2020 13:53:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405562AbgFYRxo (ORCPT ); Thu, 25 Jun 2020 13:53:44 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1EDDC08C5C1 for ; Thu, 25 Jun 2020 10:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=l1d4k+qidihXGw3BuOAQEZXl3baPIxHcq6E/8njfyIc=; b=JXnUiNef+bq/piCj7t4r6mEvl AZLUv+VYvk7HjKiZebcKDW8xJZOaCs42Q6pnKVbV5kEded5a4gPNPVnIeOvzloRQVRej6TrHp6Y/U MrV33WPChaBe/6UNu2GDma+oq5fL/zmHoBs4j5lT+9CzqHFBPCQdlTlIrZWVBIwQclbmfF7+kqiGm PewOG1FUMkJeRoujCie6apjrkZQ/sBvvL3kmpe7bdl0UosmBF9gyRv1aoYZ9ILfC289k8wO8EwStK fyPIuS3nRddSkhJ4I0y1zB2xTQtCF0e71N0O+504TA8C1wft/Mlr1j4PMYUIu5r6X249gD5O76bvK IjxCuSpzA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:59670) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1joW4B-0004f9-Ak; Thu, 25 Jun 2020 18:53:39 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1joW48-0003C7-H8; Thu, 25 Jun 2020 18:53:36 +0100 Date: Thu, 25 Jun 2020 18:53:36 +0100 From: Russell King - ARM Linux admin To: Vladimir Oltean Cc: "David S. Miller" , netdev , Andrew Lunn , Florian Fainelli , Vivien Didelot , Claudiu Manoil , Alexandru Marginean , Ioana Ciornei Subject: Re: [PATCH net-next 4/7] net: dsa: felix: set proper pause frame timers based on link speed Message-ID: <20200625175336.GM1551@shell.armlinux.org.uk> References: <20200625152331.3784018-1-olteanv@gmail.com> <20200625152331.3784018-5-olteanv@gmail.com> <20200625163715.GH1551@shell.armlinux.org.uk> <20200625165818.GK1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jun 25, 2020 at 08:06:08PM +0300, Vladimir Oltean wrote: > On Thu, 25 Jun 2020 at 19:58, Russell King - ARM Linux admin > wrote: > > > > On Thu, Jun 25, 2020 at 07:48:23PM +0300, Vladimir Oltean wrote: > > > On Thu, 25 Jun 2020 at 19:37, Russell King - ARM Linux admin > > > wrote: > > > > > > > > On Thu, Jun 25, 2020 at 06:23:28PM +0300, Vladimir Oltean wrote: > > > > > From: Vladimir Oltean > > > > > > > > > > state->speed holds a value of 10, 100, 1000 or 2500, but > > > > > SYS_MAC_FC_CFG_FC_LINK_SPEED expects a value in the range 0, 1, 2 or 3. > > > > > > > > > > So set the correct speed encoding into this register. > > > > > > > > > > Signed-off-by: Vladimir Oltean > > > > > --- > > > > > drivers/net/dsa/ocelot/felix.c | 27 +++++++++++++++++++++++---- > > > > > 1 file changed, 23 insertions(+), 4 deletions(-) > > > > > > > > > > diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c > > > > > index d229cb5d5f9e..da337c63e7ca 100644 > > > > > --- a/drivers/net/dsa/ocelot/felix.c > > > > > +++ b/drivers/net/dsa/ocelot/felix.c > > > > > @@ -250,10 +250,25 @@ static void felix_phylink_mac_config(struct dsa_switch *ds, int port, > > > > > DEV_CLOCK_CFG_LINK_SPEED(OCELOT_SPEED_1000), > > > > > DEV_CLOCK_CFG); > > > > > > > > > > - /* Flow control. Link speed is only used here to evaluate the time > > > > > - * specification in incoming pause frames. > > > > > - */ > > > > > - mac_fc_cfg = SYS_MAC_FC_CFG_FC_LINK_SPEED(state->speed); > > > > > + switch (state->speed) { > > > > > + case SPEED_10: > > > > > + mac_fc_cfg = SYS_MAC_FC_CFG_FC_LINK_SPEED(3); > > > > > + break; > > > > > + case SPEED_100: > > > > > + mac_fc_cfg = SYS_MAC_FC_CFG_FC_LINK_SPEED(2); > > > > > + break; > > > > > + case SPEED_1000: > > > > > + case SPEED_2500: > > > > > + mac_fc_cfg = SYS_MAC_FC_CFG_FC_LINK_SPEED(1); > > > > > + break; > > > > > + case SPEED_UNKNOWN: > > > > > + mac_fc_cfg = SYS_MAC_FC_CFG_FC_LINK_SPEED(0); > > > > > + break; > > > > > + default: > > > > > + dev_err(ocelot->dev, "Unsupported speed on port %d: %d\n", > > > > > + port, state->speed); > > > > > + return; > > > > > + } > > > > > > > > > > /* handle Rx pause in all cases, with 2500base-X this is used for rate > > > > > * adaptation. > > > > > @@ -265,6 +280,10 @@ static void felix_phylink_mac_config(struct dsa_switch *ds, int port, > > > > > SYS_MAC_FC_CFG_PAUSE_VAL_CFG(0xffff) | > > > > > SYS_MAC_FC_CFG_FC_LATENCY_CFG(0x7) | > > > > > SYS_MAC_FC_CFG_ZERO_PAUSE_ENA; > > > > > + > > > > > + /* Flow control. Link speed is only used here to evaluate the time > > > > > + * specification in incoming pause frames. > > > > > + */ > > > > > ocelot_write_rix(ocelot, mac_fc_cfg, SYS_MAC_FC_CFG, port); > > > > > > > > I'm not that happy with the persistence of felix using the legacy > > > > method; I can bring a horse to water but can't make it drink comes > > > > to mind. I'm at the point where I don't care _if_ my phylink changes > > > > break code that I've asked people to convert and they haven't yet, > > > > and I'm planning to send the series that /may/ cause breakage in > > > > that regard pretty soon, so the lynx PCS changes can move forward. > > > > > > > > I even tried to move felix forward by sending a patch for it, and I > > > > just gave up with that approach based on your comment. > > > > > > > > Shrug. > > > > > > > > -- > > > > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > > > > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! > > > > > > The callbacks clearly work the way they are, given the current > > > structure of phylink, as proven by the users of this driver. Code that > > > isn't there yet simply isn't there yet. > > > > > > What you consider "useless churn" and what I consider "useless churn" > > > are pretty different things. > > > To me, patch 7/7 is the useless churn, that's why it's at the end. > > > Patches 1-6 are structured in a way that is compatible with > > > backporting to a stable 5.4 tree. Patch 7, not so much. > > > > > > The fact that you have such an attitude and you make the effort to > > > actually send an email complaining about me using state->speed in > > > .mac_config(), when literally 3 patches later I'm moving this > > > configuration where you want it to be, is pretty annoying. > > > > I have asked you to update felix _prior_ to my patch update, because > > I forsee the possibility for there to be breakage from pushing the > > PCS support further forward. In other words, I see there to be a > > dependency between moving forward with PCS support and drivers that > > still use the legacy method. > > > > You don't see that, so you constantly bitch and moan. > > > > And that's what this patch series is, no? > Some cleanup needed to be done, and it needed to be done _before_ the > mac_link_up() conversion. And for things to go quicker, the cleanup > and the conversion are part of the same series. Right, which is what I find when I eventually get to patch 7, the patch that you called above "useless churn." I'm not going to review patch 7 tonight because of this fiasco. To pissed off to do a decent job, so you're just going to have to wait. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!