From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D01A3C433E1 for ; Thu, 25 Jun 2020 20:40:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3AD220791 for ; Thu, 25 Jun 2020 20:40:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=fieldses.org header.i=@fieldses.org header.b="gj0MuGKT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391047AbgFYUkb (ORCPT ); Thu, 25 Jun 2020 16:40:31 -0400 Received: from fieldses.org ([173.255.197.46]:53300 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390477AbgFYUka (ORCPT ); Thu, 25 Jun 2020 16:40:30 -0400 Received: by fieldses.org (Postfix, from userid 2815) id 1C8E879A1; Thu, 25 Jun 2020 16:40:29 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.11.0 fieldses.org 1C8E879A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fieldses.org; s=default; t=1593117629; bh=grAX8yggjJQZeEuTqT849+RECeUjWPrYL7L8CDwHWzM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gj0MuGKTpqfBnugVSHAllzwtU32mbRNrz5LhpqXoB8FX/dI6FdoUiXA6zXnyorll9 J8Wg0vYTe1AOKJQyhZwkkl/QiRqNB70nQBPja5EppPVNzeFep+Z8g/ySzPNxVjIaPi XVxnHn82AD79SvIa9xchcmtUWE/pnD9cata6TvZo= Date: Thu, 25 Jun 2020 16:40:29 -0400 From: Bruce Fields To: Chuck Lever Cc: Christophe Leroy , Trond Myklebust , Anna Schumaker , "David S. Miller" , Jakub Kicinski , netdev , Linux NFS Mailing List , linuxppc-dev@lists.ozlabs.org, Linux Kernel Mailing List Subject: Re: [PATCH v2] SUNRPC: Add missing definition of ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE Message-ID: <20200625204029.GD6605@fieldses.org> References: <9e9882a2fb57b6f9d98a0a5d8b6bf9cff9fcbd93.1592202173.git.christophe.leroy@csgroup.eu> <733E4CAF-A9E5-491F-B0C7-69CA84E5DFA5@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <733E4CAF-A9E5-491F-B0C7-69CA84E5DFA5@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 15, 2020 at 08:33:40AM -0400, Chuck Lever wrote: > > > > On Jun 15, 2020, at 2:25 AM, Christophe Leroy wrote: > > > > Even if that's only a warning, not including asm/cacheflush.h > > leads to svc_flush_bvec() being empty allthough powerpc defines > > ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE. > > > > CC net/sunrpc/svcsock.o > > net/sunrpc/svcsock.c:227:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined [-Wundef] > > #if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE > > ^ > > > > Include linux/highmem.h so that asm/cacheflush.h will be included. > > > > Reported-by: Christophe Leroy > > Reported-by: kernel test robot > > Cc: Chuck Lever > > Fixes: ca07eda33e01 ("SUNRPC: Refactor svc_recvfrom()") > > Signed-off-by: Christophe Leroy > > LGTM. > > Acked-by: Chuck Lever Thanks, applying for 5.8.--b.