From: Andrew Lunn <andrew@lunn.ch>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev <netdev@vger.kernel.org>, Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH ethtool v3 1/6] Add cable test support
Date: Thu, 25 Jun 2020 23:46:38 +0200 [thread overview]
Message-ID: <20200625214638.GC535869@lunn.ch> (raw)
In-Reply-To: <20200625211227.hvo3a5kbmsymzkz6@lion.mk-sys.cz>
> > +static int nl_cable_test_ntf_attr(struct nlattr *evattr)
> > +{
> > + unsigned int cm;
> > + uint16_t code;
> > + uint8_t pair;
> > + int ret;
> > +
> > + switch (mnl_attr_get_type(evattr)) {
> > + case ETHTOOL_A_CABLE_NEST_RESULT:
> > + ret = nl_get_cable_test_result(evattr, &pair, &code);
> > + if (ret < 0)
> > + return ret;
> > +
> > + printf("Pair: %s, result: %s\n", nl_pair2txt(pair),
> > + nl_code2txt(code));
>
> AFAICS this will produce output like "Pair: Pair A, ..." which looks
> a bit strange, is it intended? (The same below).
Hi Michal
The later patch which adds JSON support changes this. The Pair: gets
removed. I thought it was odd as well. But it did not go back through
the patches and change where is was initially added.
Andrew
next prev parent reply other threads:[~2020-06-25 21:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 19:24 [PATCH ethtool v3 0/6] ethtool(1) cable test support Andrew Lunn
2020-06-25 19:24 ` [PATCH ethtool v3 1/6] Add " Andrew Lunn
2020-06-25 21:12 ` Michal Kubecek
2020-06-25 21:46 ` Andrew Lunn [this message]
2020-06-25 19:24 ` [PATCH ethtool v3 2/6] Add cable test TDR support Andrew Lunn
2020-06-25 21:29 ` Michal Kubecek
2020-06-25 19:24 ` [PATCH ethtool v3 3/6] json_writer/json_print: Import the iproute2 helper code for JSON output Andrew Lunn
2020-06-25 19:24 ` [PATCH ethtool v3 4/6] Add --json command line argument parsing Andrew Lunn
2020-06-25 19:24 ` [PATCH ethtool v3 5/6] ethtool.8.in: Document the cable test commands Andrew Lunn
2020-06-25 19:24 ` [PATCH ethtool v3 6/6] ethtool.8.in: Add --json option Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625214638.GC535869@lunn.ch \
--to=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).