From: David Miller <davem@davemloft.net>
To: dgcbueu@gmail.com
Cc: netdev@vger.kernel.org, thomas.petazzoni@bootlin.com,
andrew@lunn.ch, rmk+kernel@armlinux.org.uk, f.fainelli@gmail.com
Subject: Re: [PATCH v2] net: mvneta: speed down the PHY, if WoL used, to save energy
Date: Fri, 26 Jun 2020 13:36:50 -0700 (PDT) [thread overview]
Message-ID: <20200626.133650.2064799999224373059.davem@davemloft.net> (raw)
In-Reply-To: <24932419.y57xhLMsBk@tool>
From: Daniel González Cabanelas <dgcbueu@gmail.com>
Date: Fri, 26 Jun 2020 17:18:19 +0200
> Some PHYs connected to this ethernet hardware support the WoL feature.
> But when WoL is enabled and the machine is powered off, the PHY remains
> waiting for a magic packet at max speed (i.e. 1Gbps), which is a waste of
> energy.
>
> Slow down the PHY speed before stopping the ethernet if WoL is enabled,
> and save some energy while the machine is powered off or sleeping.
>
> Tested using an Armada 370 based board (LS421DE) equipped with a Marvell
> 88E1518 PHY.
>
> Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
> ---
> Changes in v2:
> - Patch reworked with the new phylink_speed_(up|down) functions
> provided by Russel King. This should avoid the kernel OOPs issue when
> used with a switch or a PHY on a SFP module.
Applied to net-next.
prev parent reply other threads:[~2020-06-26 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 15:18 [PATCH v2] net: mvneta: speed down the PHY, if WoL used, to save energy Daniel González Cabanelas
2020-06-26 20:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626.133650.2064799999224373059.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=dgcbueu@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox