From: Christoph Hellwig <hch@lst.de>
To: "Björn Töpel" <bjorn.topel@intel.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: the XSK buffer pool needs be to reverted
Date: Fri, 26 Jun 2020 09:47:25 +0200 [thread overview]
Message-ID: <20200626074725.GA21790@lst.de> (raw)
Hi Björn,
you addition of the xsk_buff_pool.c APIs in commit 2b43470add8c
("xsk: Introduce AF_XDP buffer allocation API") is unfortunately rather
broken by making lots of assumptions and poking into dma-direct and
swiotlb internals that are of no business to outside users and clearly
marked as such. I'd be glad to work with your doing something proper
for pools, but that needs proper APIs and probably live in the dma
mapping core, but for that you'd actually need to contact the relevant
maintainers before poking into internals.
The commit seems to have a long dove tail of commits depending on it
despite only being a month old, so maybe you can do the revert for now?
Note that this is somewhat urgent, as various of the APIs that the code
is abusing are slated to go away for Linux 5.9, so this addition comes
at a really bad time.
next reply other threads:[~2020-06-26 7:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 7:47 Christoph Hellwig [this message]
2020-06-26 12:22 ` the XSK buffer pool needs be to reverted Björn Töpel
2020-06-26 12:41 ` Christoph Hellwig
2020-06-26 12:45 ` Björn Töpel
2020-06-26 20:54 ` Jonathan Lemon
2020-06-27 7:02 ` Christoph Hellwig
2020-06-29 13:15 ` Robin Murphy
2020-06-30 19:08 ` Jonathan Lemon
2020-07-01 9:46 ` Robin Murphy
2020-07-06 19:59 ` Jonathan Lemon
2020-07-07 17:35 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626074725.GA21790@lst.de \
--to=hch@lst.de \
--cc=bjorn.topel@intel.com \
--cc=davem@davemloft.net \
--cc=iommu@lists.linux-foundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).