From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE95FC433DF for ; Fri, 26 Jun 2020 07:47:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B30B9207E8 for ; Fri, 26 Jun 2020 07:47:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728836AbgFZHr3 (ORCPT ); Fri, 26 Jun 2020 03:47:29 -0400 Received: from verein.lst.de ([213.95.11.211]:50706 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728111AbgFZHr2 (ORCPT ); Fri, 26 Jun 2020 03:47:28 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 9C65868B02; Fri, 26 Jun 2020 09:47:25 +0200 (CEST) Date: Fri, 26 Jun 2020 09:47:25 +0200 From: Christoph Hellwig To: =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , "David S. Miller" , netdev@vger.kernel.org, Konrad Rzeszutek Wilk , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: the XSK buffer pool needs be to reverted Message-ID: <20200626074725.GA21790@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.17 (2007-11-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Björn, you addition of the xsk_buff_pool.c APIs in commit 2b43470add8c ("xsk: Introduce AF_XDP buffer allocation API") is unfortunately rather broken by making lots of assumptions and poking into dma-direct and swiotlb internals that are of no business to outside users and clearly marked as such. I'd be glad to work with your doing something proper for pools, but that needs proper APIs and probably live in the dma mapping core, but for that you'd actually need to contact the relevant maintainers before poking into internals. The commit seems to have a long dove tail of commits depending on it despite only being a month old, so maybe you can do the revert for now? Note that this is somewhat urgent, as various of the APIs that the code is abusing are slated to go away for Linux 5.9, so this addition comes at a really bad time.