netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Calvin Johnson <calvin.johnson@oss.nxp.com>
Cc: Jeremy Linton <jeremy.linton@arm.com>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Jon <jon@solid-run.com>,
	Cristi Sovaiala <cristian.sovaiala@nxp.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Madalin Bucur <madalin.bucur@oss.nxp.com>,
	linux-acpi@vger.kernel.org, linux.cj@gmail.com,
	netdev@vger.kernel.org,
	"Rajesh V. Bikkina" <rajesh.bikkina@nxp.com>
Subject: Re: [net-next PATCH v1] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver
Date: Fri, 26 Jun 2020 15:39:42 +0200	[thread overview]
Message-ID: <20200626133942.GD504133@lunn.ch> (raw)
In-Reply-To: <20200626132024.GA15707@lsv03152.swis.in-blr01.nxp.com>

> Hi Andrew
> 
> As you know, making this code generic would bring us back to waiting for
> ACPI team's approval which is very difficult to get as the ACPI doesn't
> have any opinion on MDIO bus.
> 
> Like other ACPI ethernet drivers, can't we keep it local to this driver to
> avoid the above issue?

Hi Calvin

That does not scale. Every driver doing its own thing. Each having its
own bugs, maintenance overheads, documentation problems, no meta
validation of the ACPI tables because every table is different,
etc. Where is the Advanced in that? It sounds more like Primitive,
Chaotic, Antiquated?

Plus having it generic means there is one place which needs
modifications when the ACPI standards committee does decide how this
should be done.

> If we plan to make this approach generic, then it may have to be put in:
> Documentation/firmware-guide/acpi/

So looking in this directory, we have defacto standards,
e.g. linux/Documentation/firmware-guide/acpi/dsd/leds.rst.

So lets add another defacto standard, how you find a PHY.

   Andrew

  reply	other threads:[~2020-06-26 13:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25  4:35 [net-next PATCH v1] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Calvin Johnson
2020-06-25  7:59 ` Ioana Ciornei
2020-06-25  9:46   ` Calvin Johnson
2020-06-25 19:42 ` Andrew Lunn
2020-06-26 13:20   ` Calvin Johnson
2020-06-26 13:39     ` Andrew Lunn [this message]
2020-06-26 14:02       ` Calvin Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200626133942.GD504133@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andy.shevchenko@gmail.com \
    --cc=calvin.johnson@oss.nxp.com \
    --cc=cristian.sovaiala@nxp.com \
    --cc=f.fainelli@gmail.com \
    --cc=ioana.ciornei@nxp.com \
    --cc=jeremy.linton@arm.com \
    --cc=jon@solid-run.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux.cj@gmail.com \
    --cc=linux@armlinux.org.uk \
    --cc=madalin.bucur@oss.nxp.com \
    --cc=netdev@vger.kernel.org \
    --cc=rajesh.bikkina@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).