From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 717F1C433DF for ; Fri, 26 Jun 2020 13:39:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 492CD2081A for ; Fri, 26 Jun 2020 13:39:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728431AbgFZNjt (ORCPT ); Fri, 26 Jun 2020 09:39:49 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:33866 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726169AbgFZNjt (ORCPT ); Fri, 26 Jun 2020 09:39:49 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jooZy-002NAM-1d; Fri, 26 Jun 2020 15:39:42 +0200 Date: Fri, 26 Jun 2020 15:39:42 +0200 From: Andrew Lunn To: Calvin Johnson Cc: Jeremy Linton , Russell King - ARM Linux admin , Jon , Cristi Sovaiala , Ioana Ciornei , Andy Shevchenko , Florian Fainelli , Madalin Bucur , linux-acpi@vger.kernel.org, linux.cj@gmail.com, netdev@vger.kernel.org, "Rajesh V. Bikkina" Subject: Re: [net-next PATCH v1] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Message-ID: <20200626133942.GD504133@lunn.ch> References: <20200625043538.25464-1-calvin.johnson@oss.nxp.com> <20200625194211.GA535869@lunn.ch> <20200626132024.GA15707@lsv03152.swis.in-blr01.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200626132024.GA15707@lsv03152.swis.in-blr01.nxp.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Hi Andrew > > As you know, making this code generic would bring us back to waiting for > ACPI team's approval which is very difficult to get as the ACPI doesn't > have any opinion on MDIO bus. > > Like other ACPI ethernet drivers, can't we keep it local to this driver to > avoid the above issue? Hi Calvin That does not scale. Every driver doing its own thing. Each having its own bugs, maintenance overheads, documentation problems, no meta validation of the ACPI tables because every table is different, etc. Where is the Advanced in that? It sounds more like Primitive, Chaotic, Antiquated? Plus having it generic means there is one place which needs modifications when the ACPI standards committee does decide how this should be done. > If we plan to make this approach generic, then it may have to be put in: > Documentation/firmware-guide/acpi/ So looking in this directory, we have defacto standards, e.g. linux/Documentation/firmware-guide/acpi/dsd/leds.rst. So lets add another defacto standard, how you find a PHY. Andrew