From: kernel test robot <lkp@intel.com>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>,
Bjorn Helgaas <helgaas@kernel.org>,
bjorn@helgaas.com, Vaibhav Gupta <vaibhav.varodek@gmail.com>,
Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kbuild-all@lists.01.org, devel@driverdev.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH v1 1/4] qlge/qlge_main.c: use genric power management
Date: Tue, 30 Jun 2020 00:09:36 +0800 [thread overview]
Message-ID: <202006300026.hCr1U7Sc%lkp@intel.com> (raw)
In-Reply-To: <20200629082819.216405-2-vaibhavgupta40@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3757 bytes --]
Hi Vaibhav,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v5.8-rc3 next-20200629]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/drivers-staging-use-generic-power-management/20200629-163141
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 347fa58ff5558075eec98725029c443c80ffbf4a
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/staging/qlge/qlge_main.c: In function 'qlge_resume':
>> drivers/staging/qlge/qlge_main.c:4793:17: error: 'pdev' undeclared (first use in this function); did you mean 'qdev'?
4793 | pci_set_master(pdev);
| ^~~~
| qdev
drivers/staging/qlge/qlge_main.c:4793:17: note: each undeclared identifier is reported only once for each function it appears in
vim +4793 drivers/staging/qlge/qlge_main.c
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4786
1aed508211e137 drivers/staging/qlge/qlge_main.c Vaibhav Gupta 2020-06-29 4787 static int __maybe_unused qlge_resume(struct device *dev_d)
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4788 {
1aed508211e137 drivers/staging/qlge/qlge_main.c Vaibhav Gupta 2020-06-29 4789 struct net_device *ndev = dev_get_drvdata(dev_d);
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4790 struct ql_adapter *qdev = netdev_priv(ndev);
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4791 int err;
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4792
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 @4793 pci_set_master(pdev);
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4794
1aed508211e137 drivers/staging/qlge/qlge_main.c Vaibhav Gupta 2020-06-29 4795 device_wakeup_disable(dev_d);
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4796
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4797 if (netif_running(ndev)) {
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4798 err = ql_adapter_up(qdev);
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4799 if (err)
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4800 return err;
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4801 }
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4802
72046d84f0d6e3 drivers/net/qlge/qlge_main.c Breno Leitao 2010-07-01 4803 mod_timer(&qdev->timer, jiffies + (5 * HZ));
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4804 netif_device_attach(ndev);
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4805
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4806 return 0;
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4807 }
c4e84bde1d595d drivers/net/qlge/qlge_main.c Ron Mercer 2008-09-18 4808
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49264 bytes --]
next prev parent reply other threads:[~2020-06-29 18:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 8:28 [PATCH v1 0/4] drivers/staging: use generic power management Vaibhav Gupta
2020-06-29 8:28 ` [PATCH v1 1/4] qlge/qlge_main.c: use genric " Vaibhav Gupta
2020-06-29 16:09 ` kernel test robot [this message]
2020-06-29 17:06 ` Vaibhav Gupta
2020-06-29 17:31 ` Bjorn Helgaas
2020-06-30 0:21 ` [kbuild-all] " Philip Li
2020-06-29 8:28 ` [PATCH v1 2/4] staging/rtl8192e: use generic " Vaibhav Gupta
2020-06-29 8:28 ` [PATCH v1 3/4] rts5208/rtsx.c: " Vaibhav Gupta
2020-06-29 8:28 ` [PATCH v1 4/4] vt6655/device_main.c: " Vaibhav Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006300026.hCr1U7Sc%lkp@intel.com \
--to=lkp@intel.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=bjorn@helgaas.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vaibhav.varodek@gmail.com \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).