From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D70CC433E1 for ; Wed, 1 Jul 2020 20:13:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69F352085B for ; Wed, 1 Jul 2020 20:13:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="k5De39mp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727104AbgGAUNU (ORCPT ); Wed, 1 Jul 2020 16:13:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727095AbgGAUNR (ORCPT ); Wed, 1 Jul 2020 16:13:17 -0400 Received: from mail-pl1-x64a.google.com (mail-pl1-x64a.google.com [IPv6:2607:f8b0:4864:20::64a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4BF8C08C5DC for ; Wed, 1 Jul 2020 13:13:17 -0700 (PDT) Received: by mail-pl1-x64a.google.com with SMTP id q19so14854932pls.7 for ; Wed, 01 Jul 2020 13:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=Ad9C5uLahkSIPyWJgO1D3o2iIwB9TsBxO1NANkErTuM=; b=k5De39mpv5M9E4DyG0KPOpg7dz+geldPUSWUvDcQeQ022JKmZlJalx1fLPOyYKrHma LDcUqAks+wCM+6bTRbk22M/7sFOfoc/TmpFXRXhd0Nq03TDjoOPHKGpl2ztNadOkc7F5 1xE01ANFE98ww2sPnBOkQjGqksBi58GgYKf3WB8APKrpGo6YGVWeI6fHBozNwtH680a/ 06KZRBHkz1rRH7Cs3BubONYEoMlNQ4/Ivc32mwqQ0uhXVTNSlL2Yz2HEDPsooC5qvvLa HsdkQpsvhRbyC19LfWt7S6JLfAM3kxf/n8OFuRj3Q4HflFErdNOJM6gEdFURLsl/m1cH D8SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=Ad9C5uLahkSIPyWJgO1D3o2iIwB9TsBxO1NANkErTuM=; b=UUlY7e2ggKXf/VTL3aua3YkI011cfDp/enDnpQRT6cGrvCgRdylvHhcYfiwtHVJrAw lWa1jeZbXbAdlMIeIMwZnkTe+0QBQnRrqtkJJRRO3we2hpqByCbCV0yipgoxSZa1ov5s 3ff3RshRmxE0zDYeMHYPvdJn019AoRnYH/R+5K8E+x8UOgH4dAN4Y6wijFiCx0q0ymSA CYdAurX3jCHOV4MW5L+fJ4ZCXxykvy3LNfUD2N6gRXhGc22qza5j9hGDeIBKUXmasxsO VIhcOKEaOd0VdNhU0yusukRDJOtEo6OJ8b8HPUV85ajliOaXnGudKYy5SahesxjtMJPv z4iw== X-Gm-Message-State: AOAM531psKRuZ1x2rgGsTetoAqTx4mf8JgURh3Eg3G0rHdUKPoEMC8DQ b9icCXXODWM1js12Eq+MOOz8bZ0nKSRsvLE5KsHi0ioSCGm2PeU0CC76C4OoxLfE1b9Gnvd43kE ASEuAD8PJRwfJJYhwkE7a1UOcJNyQKy6ZXaAF8bNJ4zNBLLaEegfwQw== X-Google-Smtp-Source: ABdhPJyHNKxAD7DnQh+lXn42+VFi5PlLvtt3s8loSTq+5XmYVRV4R7c13S6K53SH/Ri889B0suWgMJs= X-Received: by 2002:a17:90a:1c16:: with SMTP id s22mr29307947pjs.108.1593634396942; Wed, 01 Jul 2020 13:13:16 -0700 (PDT) Date: Wed, 1 Jul 2020 13:13:07 -0700 In-Reply-To: <20200701201307.855717-1-sdf@google.com> Message-Id: <20200701201307.855717-5-sdf@google.com> Mime-Version: 1.0 References: <20200701201307.855717-1-sdf@google.com> X-Mailer: git-send-email 2.27.0.212.ge8ba1cc988-goog Subject: [PATCH bpf-next v3 4/4] selftests/bpf: test BPF_CGROUP_INET_SOCK_RELEASE From: Stanislav Fomichev To: netdev@vger.kernel.org, bpf@vger.kernel.org Cc: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, Stanislav Fomichev Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Simple test that enforces a single SOCK_DGRAM socker per cgroup. Signed-off-by: Stanislav Fomichev --- .../selftests/bpf/prog_tests/udp_limit.c | 72 +++++++++++++++++++ tools/testing/selftests/bpf/progs/udp_limit.c | 42 +++++++++++ 2 files changed, 114 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/udp_limit.c create mode 100644 tools/testing/selftests/bpf/progs/udp_limit.c diff --git a/tools/testing/selftests/bpf/prog_tests/udp_limit.c b/tools/testing/selftests/bpf/prog_tests/udp_limit.c new file mode 100644 index 000000000000..510c928c1496 --- /dev/null +++ b/tools/testing/selftests/bpf/prog_tests/udp_limit.c @@ -0,0 +1,72 @@ +// SPDX-License-Identifier: GPL-2.0 +#include +#include "udp_limit.skel.h" + +#include +#include + +static int duration; + +void test_udp_limit(void) +{ + struct udp_limit *skel; + int cgroup_fd; + int fd1, fd2; + + cgroup_fd = test__join_cgroup("/udp_limit"); + if (CHECK(cgroup_fd < 0, "cg-join", "errno %d", errno)) + return; + + skel = udp_limit__open_and_load(); + if (CHECK(!skel, "skel-load", "errno %d", errno)) + goto close_cgroup_fd; + + skel->links.sock = bpf_program__attach_cgroup(skel->progs.sock, cgroup_fd); + skel->links.sock_release = bpf_program__attach_cgroup(skel->progs.sock_release, cgroup_fd); + if (CHECK(IS_ERR(skel->links.sock) || IS_ERR(skel->links.sock_release), + "cg-attach", "sock %ld sock_release %ld", + PTR_ERR(skel->links.sock), + PTR_ERR(skel->links.sock_release))) + goto close_skeleton; + + /* BPF program enforces a single UDP socket per cgroup, + * verify that. + */ + fd1 = socket(AF_INET, SOCK_DGRAM, 0); + if (CHECK(fd1 < 0, "fd1", "errno %d", errno)) + goto close_skeleton; + + fd2 = socket(AF_INET, SOCK_DGRAM, 0); + if (CHECK(fd2 >= 0, "fd2", "errno %d", errno)) + goto close_fd1; + + /* We can reopen again after close. */ + close(fd1); + + fd1 = socket(AF_INET, SOCK_DGRAM, 0); + if (CHECK(fd1 < 0, "fd1-again", "errno %d", errno)) + goto close_skeleton; + + /* Make sure the program was invoked the expected + * number of times: + * - open fd1 - BPF_CGROUP_INET_SOCK_CREATE + * - attempt to openfd2 - BPF_CGROUP_INET_SOCK_CREATE + * - close fd1 - BPF_CGROUP_INET_SOCK_RELEASE + * - open fd1 again - BPF_CGROUP_INET_SOCK_CREATE + */ + if (CHECK(skel->bss->invocations != 4, "bss-invocations", + "invocations=%d", skel->bss->invocations)) + goto close_fd1; + + /* We should still have a single socket in use */ + if (CHECK(skel->bss->in_use != 1, "bss-in_use", + "in_use=%d", skel->bss->in_use)) + goto close_fd1; + +close_fd1: + close(fd1); +close_skeleton: + udp_limit__destroy(skel); +close_cgroup_fd: + close(cgroup_fd); +} diff --git a/tools/testing/selftests/bpf/progs/udp_limit.c b/tools/testing/selftests/bpf/progs/udp_limit.c new file mode 100644 index 000000000000..af1154bfb946 --- /dev/null +++ b/tools/testing/selftests/bpf/progs/udp_limit.c @@ -0,0 +1,42 @@ +// SPDX-License-Identifier: GPL-2.0-only + +#include +#include +#include + +int invocations, in_use; + +SEC("cgroup/sock") +int sock(struct bpf_sock *ctx) +{ + __u32 key; + + if (ctx->type != SOCK_DGRAM) + return 1; + + __sync_fetch_and_add(&invocations, 1); + + if (in_use > 0) { + /* BPF_CGROUP_INET_SOCK_RELEASE is _not_ called + * when we return an error from the BPF + * program! + */ + return 0; + } + + __sync_fetch_and_add(&in_use, 1); + return 1; +} + +SEC("cgroup/sock_release") +int sock_release(struct bpf_sock *ctx) +{ + __u32 key; + + if (ctx->type != SOCK_DGRAM) + return 1; + + __sync_fetch_and_add(&invocations, 1); + __sync_fetch_and_add(&in_use, -1); + return 1; +} -- 2.27.0.212.ge8ba1cc988-goog