From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AFCCC433DF for ; Thu, 2 Jul 2020 21:24:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66E2E2088E for ; Thu, 2 Jul 2020 21:24:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726110AbgGBVYf (ORCPT ); Thu, 2 Jul 2020 17:24:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725937AbgGBVYe (ORCPT ); Thu, 2 Jul 2020 17:24:34 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86B41C08C5C1; Thu, 2 Jul 2020 14:24:34 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 21B44128448F0; Thu, 2 Jul 2020 14:24:34 -0700 (PDT) Date: Thu, 02 Jul 2020 14:24:33 -0700 (PDT) Message-Id: <20200702.142433.1250386458271188648.davem@davemloft.net> To: weiyongjun1@huawei.com Cc: hulkci@huawei.com, tariqt@mellanox.com, kuba@kernel.org, vaibhavgupta40@gmail.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH net-next] mlx4: Mark PM functions as __maybe_unused From: David Miller In-Reply-To: <20200702091946.5144-1-weiyongjun1@huawei.com> References: <20200702091946.5144-1-weiyongjun1@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 02 Jul 2020 14:24:34 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Wei Yongjun Date: Thu, 2 Jul 2020 17:19:46 +0800 > In certain configurations without power management support, the > following warnings happen: > > drivers/net/ethernet/mellanox/mlx4/main.c:4388:12: > warning: 'mlx4_resume' defined but not used [-Wunused-function] > 4388 | static int mlx4_resume(struct device *dev_d) > | ^~~~~~~~~~~ > drivers/net/ethernet/mellanox/mlx4/main.c:4373:12: warning: > 'mlx4_suspend' defined but not used [-Wunused-function] > 4373 | static int mlx4_suspend(struct device *dev_d) > | ^~~~~~~~~~~~ > > Mark these functions as __maybe_unused to make it clear to the > compiler that this is going to happen based on the configuration, > which is the standard for these types of functions. > > Fixes: 0e3e206a3e12 ("mlx4: use generic power management") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun Applied.