From: Andrew Lunn <andrew@lunn.ch>
To: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH net] net: dsa: microchip: set the correct number of ports
Date: Thu, 2 Jul 2020 15:50:16 +0200 [thread overview]
Message-ID: <20200702135016.GL730739@lunn.ch> (raw)
In-Reply-To: <20200702094450.1353917-1-codrin.ciubotariu@microchip.com>
On Thu, Jul 02, 2020 at 12:44:50PM +0300, Codrin Ciubotariu wrote:
> The number of ports is incorrectly set to the maximum available for a DSA
> switch. Even if the extra ports are not used, this causes some functions
> to be called later, like port_disable() and port_stp_state_set(). If the
> driver doesn't check the port index, it will end up modifying unknown
> registers.
>
> Fixes: b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477")
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks for the minimum patch.
If you wait about a week, net will get merged into net-next. You can
then submit a refactoring patch based on your previous version.
Andrew
next prev parent reply other threads:[~2020-07-02 13:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 9:44 [PATCH net] net: dsa: microchip: set the correct number of ports Codrin Ciubotariu
2020-07-02 13:50 ` Andrew Lunn [this message]
2020-07-02 15:16 ` Codrin.Ciubotariu
2020-07-02 21:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702135016.GL730739@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=codrin.ciubotariu@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).