From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: wenxu <wenxu@ucloud.cn>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct
Date: Thu, 2 Jul 2020 14:32:28 -0300 [thread overview]
Message-ID: <20200702173228.GH74252@localhost.localdomain> (raw)
In-Reply-To: <7aaefcef-5709-04a8-0c54-c8c6066e1e90@ucloud.cn>
On Thu, Jul 02, 2020 at 05:36:38PM +0800, wenxu wrote:
>
> On 7/2/2020 1:33 AM, Cong Wang wrote:
> > On Wed, Jul 1, 2020 at 1:21 AM wenxu <wenxu@ucloud.cn> wrote:
> >>
> >> On 7/1/2020 2:21 PM, wenxu wrote:
> >>> On 7/1/2020 2:12 PM, Cong Wang wrote:
> >>>> On Tue, Jun 30, 2020 at 11:03 PM wenxu <wenxu@ucloud.cn> wrote:
> >>>>> Only forward packet case need do fragment again and there is no need do defrag explicit.
> >>>> Same question: why act_mirred? You have to explain why act_mirred
> >>>> has the responsibility to do this job.
> >>> The fragment behavior only depends on the mtu of the device sent in act_mirred. Only in
> >>>
> >>> the act_mirred can decides whether do the fragment or not.
> >> Hi cong,
> >>
> >>
> >> I still think this should be resolved in the act_mirred. Maybe it is not matter with a "responsibility"
> >>
> >> Did you have some other suggestion to solve this problem?
> > Like I said, why not introduce a new action to handle fragment/defragment?
> >
> > With that, you can still pipe it to act_ct and act_mirred to achieve
> > the same goal.
>
> Thanks. Consider about the act_fagment, There are two problem for this.
>
>
> The frag action will put the ressemble skb to more than one packets. How these packets
>
> go through the following tc filter or chain?
One idea is to listificate it, but I don't see how it can work. For
example, it can be quite an issue when jumping chains, as the match
would have to work on the list as well.
>
>
> When should use the act_fragament the action, always before the act_mirred?
Which can be messy if you consider chains like: "mirred, push vlan,
mirred" or so. "frag, mirred, defrag, push vlan, frag, mirred".
next prev parent reply other threads:[~2020-07-02 17:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 2:54 [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct wenxu
2020-06-30 15:57 ` Eric Dumazet
2020-07-01 2:27 ` wenxu
2020-06-30 19:02 ` Cong Wang
2020-07-01 2:33 ` wenxu
2020-07-01 5:52 ` Cong Wang
2020-07-01 6:02 ` wenxu
2020-07-01 6:12 ` Cong Wang
2020-07-01 6:21 ` wenxu
2020-07-01 8:17 ` wenxu
2020-07-01 17:33 ` Cong Wang
2020-07-02 9:36 ` wenxu
2020-07-02 17:32 ` Marcelo Ricardo Leitner [this message]
2020-07-02 21:39 ` Cong Wang
2020-07-03 0:47 ` Marcelo Ricardo Leitner
2020-07-03 10:19 ` wenxu
2020-07-03 17:50 ` Marcelo Ricardo Leitner
2020-07-05 14:31 ` wenxu
2020-07-06 6:02 ` Cong Wang
2020-07-06 5:59 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702173228.GH74252@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=wenxu@ucloud.cn \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).