netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Robert Marko <robert.marko@sartura.hr>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	David Miller <davem@davemloft.net>,
	kuba@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	robh+dt@kernel.org
Subject: Re: [net-next,PATCH 2/4] net: mdio-ipq4019: add clock support
Date: Fri, 3 Jul 2020 15:35:13 +0200	[thread overview]
Message-ID: <20200703133513.GB807334@lunn.ch> (raw)
In-Reply-To: <CA+HBbNHbyS3viFc90KDWW=dwkA9yRSuQ15fg9EzApmrP8JSR3Q@mail.gmail.com>

On Fri, Jul 03, 2020 at 01:37:48PM +0200, Robert Marko wrote:
> This is not the actual MDIO bus clock, that is the clock frequency
> that SoC clock generator produces.
> MDIO controller has an internal divider set up for that 100MHz, I
> don't know the actual MDIO bus clock
> frequency as it's not listed anywhere.

Hi Robert

From Documentation/devicetree/bindings/net/mdio.yaml 

  clock-frequency:
    description:
      Desired MDIO bus clock frequency in Hz. Values greater than IEEE 802.3
      defined 2.5MHz should only be used when all devices on the bus support
      the given clock speed.

You have to use that definition for clock-frequency. It means the MDIO
bus frequency. It would be good if you can get an oscilloscope onto
the bus and measure it. Otherwise, we have to assume the divider is
40, in order to give a standards compliment 2.5MHz. You can then work
out what value to pass to the clk_ API to get the correct input clock
frequency for the MDIO block.

	  Andrew

  reply	other threads:[~2020-07-03 13:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 10:29 [net-next,PATCH 0/4] net: mdio-ipq4019: add Clause 45 and clock support Robert Marko
2020-07-02 10:29 ` [net-next,PATCH 1/4] net: mdio-ipq4019: change defines to upper case Robert Marko
2020-07-02 13:25   ` Andrew Lunn
2020-07-02 19:58   ` Florian Fainelli
2020-07-02 10:29 ` [net-next,PATCH 2/4] net: mdio-ipq4019: add clock support Robert Marko
2020-07-02 13:29   ` Andrew Lunn
2020-07-02 19:59   ` Florian Fainelli
2020-07-03 11:37     ` Robert Marko
2020-07-03 13:35       ` Andrew Lunn [this message]
2020-07-02 10:30 ` [net-next,PATCH 3/4] net: mdio-ipq4019: add Clause 45 support Robert Marko
2020-07-02 13:35   ` Andrew Lunn
2020-07-02 10:30 ` [net-next,PATCH 4/4] dt-bindings: mdio-ipq4019: add clock support Robert Marko
2020-07-02 13:38   ` Andrew Lunn
2020-07-02 19:18     ` Robert Marko
2020-07-02 20:04       ` Florian Fainelli
2020-07-03  7:44         ` Robert Marko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200703133513.GB807334@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=robert.marko@sartura.hr \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).