From: Andrew Lunn <andrew@lunn.ch>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev <netdev@vger.kernel.org>, Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH ethtool v4 0/6] ethtool(1) cable test support
Date: Sun, 5 Jul 2020 18:24:21 +0200 [thread overview]
Message-ID: <20200705162421.GA884423@lunn.ch> (raw)
In-Reply-To: <20200705004447.ook7vkzffa5ejb2v@lion.mk-sys.cz>
On Sun, Jul 05, 2020 at 02:44:47AM +0200, Michal Kubecek wrote:
> On Wed, Jul 01, 2020 at 03:07:37AM +0200, Andrew Lunn wrote:
> > Add the user space side of the ethtool cable test.
> >
> > The TDR output is most useful when fed to some other tool which can
> > visualize the data. So add JSON support, by borrowing code from
> > iproute2.
> >
> > v2:
> > man page fixes.
> >
> > v3:
> > More man page fixes.
> > Use json_print from iproute2.
> >
> > v4:
> > checkpatch cleanup
> > ethtool --cable-test dev
> > Place breakout into cable_test_context
> > Remove Pair: Pair output
>
> Hello Andrew,
>
> could you please test this update of netlink/desc-ethtool.c on top of
> your series? The userspace messages look as expected but I'm not sure if
> I have a device with cable test support available to test pretty
> printing of kernel messages. (And even if I do, I almost certainly won't
> have physical access to it.)
Hi Michal
Currently there are three PHY drivers with support: Marvell, Atheros
at803x, and bcm54140. And you can do some amount of testing without
physical access, you can expect the test results to indicate the cable
is O.K.
However, i will give these a go.
Some sort of capture and reply would be interesting for this, and for
regression testing. The ability to do something like
ethtool --monitor -w test.cap
To dump the netlink socket data to a file, and
ethtool --monitor -r test.cap
to read from the file and decode its contents. Maybe this is already
possible via nlmon?
Andrew
next prev parent reply other threads:[~2020-07-05 16:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 1:07 [PATCH ethtool v4 0/6] ethtool(1) cable test support Andrew Lunn
2020-07-01 1:07 ` [PATCH ethtool v4 1/6] Add " Andrew Lunn
2020-07-04 23:43 ` Michal Kubecek
2020-07-01 1:07 ` [PATCH ethtool v4 2/6] Add cable test TDR support Andrew Lunn
2020-07-04 23:58 ` Michal Kubecek
2020-07-01 1:07 ` [PATCH ethtool v4 3/6] json_writer/json_print: Import the iproute2 helper code for JSON output Andrew Lunn
2020-07-01 1:07 ` [PATCH ethtool v4 4/6] Add --json command line argument parsing Andrew Lunn
2020-07-01 1:07 ` [PATCH ethtool v4 5/6] ethtool.8.in: Document the cable test commands Andrew Lunn
2020-07-01 1:07 ` [PATCH ethtool v4 6/6] ethtool.8.in: Add --json option Andrew Lunn
2020-07-05 0:44 ` [PATCH ethtool v4 0/6] ethtool(1) cable test support Michal Kubecek
2020-07-05 16:24 ` Andrew Lunn [this message]
2020-07-05 23:26 ` Michal Kubecek
2020-07-05 18:25 ` Andrew Lunn
2020-07-05 23:27 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200705162421.GA884423@lunn.ch \
--to=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).