From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Vasundhara Volam <vasundhara-v.volam@broadcom.com>,
netdev@vger.kernel.org, dsahern@gmail.com, davem@davemloft.net,
jiri@mellanox.com, kuba@kernel.org, michael.chan@broadcom.com
Subject: Re: [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand.
Date: Mon, 6 Jul 2020 09:33:54 -0700 [thread overview]
Message-ID: <20200706093354.7dd0edc2@hermes.lan> (raw)
In-Reply-To: <20200706063450.GA2251@nanopsycho.orion>
On Mon, 6 Jul 2020 08:34:50 +0200
Jiri Pirko <jiri@resnulli.us> wrote:
> Sun, Jul 05, 2020 at 08:03:01PM CEST, stephen@networkplumber.org wrote:
> >On Mon, 29 Jun 2020 13:13:04 +0530
> >Vasundhara Volam <vasundhara-v.volam@broadcom.com> wrote:
> >
> >> Add support for reading board serial_number to devlink info
> >> subcommand. Example:
> >>
> >> $ devlink dev info pci/0000:af:00.0 -jp
> >> {
> >> "info": {
> >> "pci/0000:af:00.0": {
> >> "driver": "bnxt_en",
> >> "serial_number": "00-10-18-FF-FE-AD-1A-00",
> >> "board.serial_number": "433551F+172300000",
> >> "versions": {
> >> "fixed": {
> >> "board.id": "7339763 Rev 0.",
> >> "asic.id": "16D7",
> >> "asic.rev": "1"
> >> },
> >> "running": {
> >> "fw": "216.1.216.0",
> >> "fw.psid": "0.0.0",
> >> "fw.mgmt": "216.1.192.0",
> >> "fw.mgmt.api": "1.10.1",
> >> "fw.ncsi": "0.0.0.0",
> >> "fw.roce": "216.1.16.0"
> >> }
> >> }
> >> }
> >> }
> >> }
> >
> >Although this is valid JSON, many JSON style guides do not allow
> >for periods in property names. This is done so libraries can use
> >dot notation to reference objects.
> >
> >Also the encoding of PCI is problematic
>
> Well, besides board.serial_number, this is what we have right now...
Could you investigate JSON usage and decide what style to use.
The rest of iproute2 doesn't do it.
next prev parent reply other threads:[~2020-07-06 16:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1593416584-24145-1-git-send-email-vasundhara-v.volam@broadcom.com>
2020-07-05 18:03 ` [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand Stephen Hemminger
2020-07-06 6:34 ` Jiri Pirko
2020-07-06 16:33 ` Stephen Hemminger [this message]
2020-07-08 9:40 ` Vasundhara Volam
2020-07-08 11:35 ` Jiri Pirko
2020-07-08 15:04 ` Vasundhara Volam
2020-07-08 15:26 ` Stephen Hemminger
2020-07-08 16:00 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706093354.7dd0edc2@hermes.lan \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vasundhara-v.volam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).