From: Chris <chris@disavowed.jp>
To: netdev@vger.kernel.org
Cc: trivial@kernel.org
Subject: [PATCH v2] net/appletalk: restore success case for atalk_proc_init()
Date: Mon, 6 Jul 2020 20:11:30 +0900 [thread overview]
Message-ID: <20200706111130.GC153765@mikkabi> (raw)
In-Reply-To: <20191008185741.10afd266@cakuba.netronome.com>
Commit e2bcd8b0ce6ee3410665765db0d44dd8b7e3b348 to
net/appletalk/atalk_proc.c removed the success case, rendering
appletalk.ko inoperable. This one-liner restores correct operation.
Fixes: e2bcd8b0ce6ee3410665765db0d44dd8b7e3b348 ("appletalk: use remove_proc_subtree to simplify procfs code")
Signed-off-by: Christopher KOBAYASHI <chris@disavowed.jp>
---
Apologies for the delay in revising this patch, life got a bit busy.
diff --git a/net/appletalk/atalk_proc.c b/net/appletalk/atalk_proc.c
index 550c6ca007cc..9c1241292d1d 100644
--- a/net/appletalk/atalk_proc.c
+++ b/net/appletalk/atalk_proc.c
@@ -229,6 +229,8 @@ int __init atalk_proc_init(void)
sizeof(struct aarp_iter_state), NULL))
goto out;
+ return 0;
+
out:
remove_proc_subtree("atalk", init_net.proc_net);
return -ENOMEM;
next prev parent reply other threads:[~2020-07-06 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 1:26 [PATCH] net/appletalk: restore success case for atalk_proc_init() Christopher KOBAYASHI
2019-10-09 1:57 ` Jakub Kicinski
2020-07-06 11:11 ` Chris [this message]
2020-07-06 19:31 ` [PATCH v2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706111130.GC153765@mikkabi \
--to=chris@disavowed.jp \
--cc=netdev@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).