[PATCH] net/appletalk: restore success case for atalk_proc_init()

[PATCH] net/appletalk: restore success case for atalk_proc_init()

[Christopher KOBAYASHI]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

Commit e2bcd8b0ce6ee3410665765db0d44dd8b7e3b348 to
net/appletalk/atalk_proc.c removed the success case, rendering
appletalk.ko inoperable.  This one-liner restores correct operation.

Signed-off-by: Christopher KOBAYASHI <chris@disavowed.jp>
---
diff --git a/net/appletalk/atalk_proc.c b/net/appletalk/atalk_proc.c
index 550c6ca007cc..9c1241292d1d 100644
--- a/net/appletalk/atalk_proc.c
+++ b/net/appletalk/atalk_proc.c
@@ -229,6 +229,8 @@ int __init atalk_proc_init(void)
 				     sizeof(struct aarp_iter_state), NULL))
 		goto out;
 
+	return 0;
+
 out:
 	remove_proc_subtree("atalk", init_net.proc_net);
 	return -ENOMEM;

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] net/appletalk: restore success case for atalk_proc_init()

[Jakub Kicinski]

On Wed, 9 Oct 2019 10:26:30 +0900, Christopher KOBAYASHI wrote:
> Commit e2bcd8b0ce6ee3410665765db0d44dd8b7e3b348 to
> net/appletalk/atalk_proc.c removed the success case, rendering
> appletalk.ko inoperable.  This one-liner restores correct operation.
> 
> Signed-off-by: Christopher KOBAYASHI <chris@disavowed.jp>

Thank you, the code looks correct!

Could you improve the commit message a little bit?
Could you add a Fixes tag and use the standard way of quoting commits?

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

Once done could you send the patch again indicating this is the second
revision in the subject?

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format

> diff --git a/net/appletalk/atalk_proc.c b/net/appletalk/atalk_proc.c
> index 550c6ca007cc..9c1241292d1d 100644
> --- a/net/appletalk/atalk_proc.c
> +++ b/net/appletalk/atalk_proc.c
> @@ -229,6 +229,8 @@ int __init atalk_proc_init(void)
>  				     sizeof(struct aarp_iter_state), NULL))
>  		goto out;
>  
> +	return 0;
> +
>  out:
>  	remove_proc_subtree("atalk", init_net.proc_net);
>  	return -ENOMEM;

[PATCH v2] net/appletalk: restore success case for atalk_proc_init()

[Chris]

Commit e2bcd8b0ce6ee3410665765db0d44dd8b7e3b348 to
net/appletalk/atalk_proc.c removed the success case, rendering
appletalk.ko inoperable.  This one-liner restores correct operation.

Fixes: e2bcd8b0ce6ee3410665765db0d44dd8b7e3b348 ("appletalk: use remove_proc_subtree to simplify procfs code")
Signed-off-by: Christopher KOBAYASHI <chris@disavowed.jp>
---

Apologies for the delay in revising this patch, life got a bit busy.

diff --git a/net/appletalk/atalk_proc.c b/net/appletalk/atalk_proc.c
index 550c6ca007cc..9c1241292d1d 100644
--- a/net/appletalk/atalk_proc.c
+++ b/net/appletalk/atalk_proc.c
@@ -229,6 +229,8 @@ int __init atalk_proc_init(void)
 				     sizeof(struct aarp_iter_state), NULL))
 		goto out;
 
+	return 0;
+
 out:
 	remove_proc_subtree("atalk", init_net.proc_net);
 	return -ENOMEM;

Re: [PATCH v2] net/appletalk: restore success case for atalk_proc_init()

[David Miller]

From: Chris <chris@disavowed.jp>
Date: Mon, 6 Jul 2020 20:11:30 +0900

> Fixes: e2bcd8b0ce6ee3410665765db0d44dd8b7e3b348 ("appletalk: use remove_proc_subtree to simplify procfs code")

12-digits of significance in SHA1 IDs in Fixes: tags please.

Also, if you mention the SHA1 ID in the Fixes tag you can elide it
from the commit message.