From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Xin Long <lucien.xin@gmail.com>,
netdev@vger.kernel.org
Cc: lkp@intel.com, kbuild-all@lists.01.org,
Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Jamal Hadi Salim <hadi@cyberus.ca>,
Sabrina Dubroca <sd@queasysnail.net>,
Tobias Brunner <tobias@strongswan.org>
Subject: Re: [PATCH ipsec] xfrm: state: match with both mark and mask on user interfaces
Date: Tue, 7 Jul 2020 16:29:13 +0300 [thread overview]
Message-ID: <20200707132913.GU2549@kadam> (raw)
In-Reply-To: <4aaead9f8306859eb652b90582f23295792e9d15.1593497708.git.lucien.xin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2081 bytes --]
Hi Xin,
url: https://github.com/0day-ci/linux/commits/Xin-Long/xfrm-state-match-with-both-mark-and-mask-on-user-interfaces/20200630-141906
base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec.git master
config: arm-randconfig-m031-20200701 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
net/xfrm/xfrm_state.c:1760 xfrm_state_lookup_user() warn: ignoring unreachable code.
# https://github.com/0day-ci/linux/commit/ef34e2d07ba51ae7e0ff334958449318e025e6b6
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout ef34e2d07ba51ae7e0ff334958449318e025e6b6
vim +1760 net/xfrm/xfrm_state.c
ef34e2d07ba51ae Xin Long 2020-06-30 1751 struct xfrm_state *
ef34e2d07ba51ae Xin Long 2020-06-30 1752 xfrm_state_lookup_user(struct net *net, const struct xfrm_mark *mark,
ef34e2d07ba51ae Xin Long 2020-06-30 1753 const xfrm_address_t *daddr, __be32 spi,
ef34e2d07ba51ae Xin Long 2020-06-30 1754 u8 proto, unsigned short family)
ef34e2d07ba51ae Xin Long 2020-06-30 1755 {
ef34e2d07ba51ae Xin Long 2020-06-30 1756 struct xfrm_state *x;
ef34e2d07ba51ae Xin Long 2020-06-30 1757
ef34e2d07ba51ae Xin Long 2020-06-30 1758 rcu_read_lock();
ef34e2d07ba51ae Xin Long 2020-06-30 1759 return __xfrm_state_lookup(net, 0, mark, daddr, spi, proto, family);
^^^^^^^
Should be "x = __xfrm_state_lookup();"
ef34e2d07ba51ae Xin Long 2020-06-30 @1760 rcu_read_unlock();
ef34e2d07ba51ae Xin Long 2020-06-30 1761 return x;
ef34e2d07ba51ae Xin Long 2020-06-30 1762 }
ef34e2d07ba51ae Xin Long 2020-06-30 1763 EXPORT_SYMBOL(xfrm_state_lookup_user);
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27431 bytes --]
prev parent reply other threads:[~2020-07-07 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 6:15 [PATCH ipsec] xfrm: state: match with both mark and mask on user interfaces Xin Long
2020-06-30 9:08 ` Tobias Brunner
2020-07-06 8:33 ` Xin Long
2020-07-07 6:17 ` Steffen Klassert
2020-07-07 9:09 ` Xin Long
2020-07-07 13:29 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707132913.GU2549@kadam \
--to=dan.carpenter@oracle.com \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=lkp@intel.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=steffen.klassert@secunet.com \
--cc=tobias@strongswan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).