From: Vladimir Oltean <olteanv@gmail.com>
To: Sergey Organov <sorganov@gmail.com>
Cc: richardcochran@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Fugang Duan <fugang.duan@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH 3/5] net: fec: initialize clock with 0 rather than current kernel time
Date: Tue, 7 Jul 2020 20:12:33 +0300 [thread overview]
Message-ID: <20200707171233.et6zrwfqq7fddz2r@skbuf> (raw)
In-Reply-To: <87sge345ho.fsf@osv.gnss.ru>
On Tue, Jul 07, 2020 at 08:09:07PM +0300, Sergey Organov wrote:
> Vladimir Oltean <olteanv@gmail.com> writes:
>
> > On Tue, Jul 07, 2020 at 07:07:08PM +0300, Sergey Organov wrote:
> >> Vladimir Oltean <olteanv@gmail.com> writes:
> >> >
> >> > What do you mean 'no ticking', and what do you mean by 'non-initialized
> >> > clock' exactly? I don't know if the fec driver is special in any way, do
> >> > you mean that multiple runs of $(phc_ctl /dev/ptp0 get) from user space
> >> > all return 0? That is not at all what is to be expected, I think. The
> >> > PHC is always ticking. Its time is increasing.
> >>
> >> That's how it is right now. My point is that it likely shouldn't. Why is
> >> it ticking when nobody needs it? Does it draw more power due to that?
> >>
> >> > What would be that initialization procedure that makes it tick, and
> >> > who is doing it (and when)?
> >>
> >> The user space code that cares, obviously. Most probably some PTP stack
> >> daemon. I'd say that any set clock time ioctl() should start the clock,
> >> or yet another ioctl() that enables/disables the clock, whatever.
> >>
> >
> > That ioctl doesn't exist, at least not in PTP land. This also addresses
> > your previous point.
>
> struct timespec ts;
> ...
> clock_settime(clkid, &ts)
>
> That's the starting point of my own code, and I bet it's there in PTP
> for Linux, as well as in PTPD, as I fail to see how it could possibly
> work without it.
>
This won't stop it from ticking, which is what we were talking about,
will it?
Thanks,
-Vladimir
next prev parent reply other threads:[~2020-07-07 17:12 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 14:26 [PATCH 0/5] net: fec: fix external PTP PHY support Sergey Organov
2020-07-06 14:26 ` [PATCH 1/5] net: fec: properly support external PTP PHY for hardware time stamping Sergey Organov
2020-07-06 15:08 ` Vladimir Oltean
2020-07-06 15:21 ` Sergey Organov
2020-07-06 15:47 ` Vladimir Oltean
2020-07-06 18:33 ` Sergey Organov
2020-07-07 7:04 ` Vladimir Oltean
2020-07-07 15:29 ` Sergey Organov
2020-07-08 11:00 ` Richard Cochran
2020-07-08 10:55 ` Richard Cochran
2020-07-06 14:26 ` [PATCH 2/5] net: fec: enable to use PPS feature without " Sergey Organov
2020-07-07 4:05 ` [EXT] " Andy Duan
2020-07-07 14:29 ` Sergey Organov
2020-07-06 14:26 ` [PATCH 3/5] net: fec: initialize clock with 0 rather than current kernel time Sergey Organov
2020-07-06 15:27 ` Vladimir Oltean
2020-07-06 18:24 ` Sergey Organov
2020-07-07 6:36 ` Vladimir Oltean
2020-07-07 16:07 ` Sergey Organov
2020-07-07 16:43 ` Vladimir Oltean
2020-07-07 17:09 ` Sergey Organov
2020-07-07 17:12 ` Vladimir Oltean [this message]
2020-07-07 17:56 ` Sergey Organov
2020-07-08 11:15 ` Richard Cochran
2020-07-08 12:14 ` Sergey Organov
2020-07-08 11:11 ` Richard Cochran
2020-07-08 11:04 ` Richard Cochran
2020-07-08 12:24 ` Sergey Organov
2020-07-08 12:37 ` Sergey Organov
2020-07-08 14:48 ` Richard Cochran
2020-07-08 17:18 ` Sergey Organov
2020-07-06 14:26 ` [PATCH 4/5] net: fec: get rid of redundant code in fec_ptp_set() Sergey Organov
2020-07-07 4:08 ` [EXT] " Andy Duan
2020-07-07 14:43 ` Sergey Organov
2020-07-08 5:34 ` Andy Duan
2020-07-08 8:48 ` Sergey Organov
2020-07-08 8:57 ` Andy Duan
2020-07-08 12:26 ` Sergey Organov
2020-07-06 14:26 ` [PATCH 5/5] net: fec: replace snprintf() with strlcpy() in fec_ptp_init() Sergey Organov
2020-07-11 12:08 ` [PATCH v2 net] net: fec: fix hardware time stamping by external devices Sergey Organov
2020-07-11 23:19 ` Vladimir Oltean
2020-07-12 14:16 ` Sergey Organov
2020-07-12 14:47 ` Andrew Lunn
2020-07-12 15:01 ` Vladimir Oltean
2020-07-12 17:29 ` Sergey Organov
2020-07-12 19:33 ` Vladimir Oltean
2020-07-12 22:32 ` Sergey Organov
2020-07-12 23:15 ` Vladimir Oltean
2020-07-14 12:39 ` Sergey Organov
2020-07-14 14:23 ` Vladimir Oltean
2020-07-14 14:35 ` Sergey Organov
2020-07-14 14:44 ` Vladimir Oltean
2020-07-14 16:18 ` Sergey Organov
2020-07-14 14:01 ` Richard Cochran
2020-07-14 14:27 ` Sergey Organov
2020-07-14 16:28 ` [PATCH v3 " Sergey Organov
2020-07-16 18:24 ` Jakub Kicinski
2020-07-16 20:38 ` Sergey Organov
2020-07-16 21:06 ` Jakub Kicinski
2020-07-16 21:18 ` Sergey Organov
2020-07-15 15:42 ` [PATCH net-next v2 0/4] net: fec: a few improvements Sergey Organov
2020-07-15 15:42 ` [PATCH net-next v2 1/4] net: fec: enable to use PPS feature without time stamping Sergey Organov
2020-07-15 15:42 ` [PATCH net-next v2 2/4] net: fec: initialize clock with 0 rather than current kernel time Sergey Organov
2020-07-15 15:42 ` [PATCH net-next v2 3/4] net: fec: get rid of redundant code in fec_ptp_set() Sergey Organov
2020-07-15 15:43 ` [PATCH net-next v2 4/4] net: fec: replace snprintf() with strlcpy() in fec_ptp_init() Sergey Organov
2020-07-16 3:00 ` [EXT] [PATCH net-next v2 0/4] net: fec: a few improvements Andy Duan
2020-07-16 18:37 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707171233.et6zrwfqq7fddz2r@skbuf \
--to=olteanv@gmail.com \
--cc=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=sorganov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox