From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C5CCC433E1 for ; Thu, 9 Jul 2020 16:07:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC71A20767 for ; Thu, 9 Jul 2020 16:07:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728244AbgGIQHM (ORCPT ); Thu, 9 Jul 2020 12:07:12 -0400 Received: from mga03.intel.com ([134.134.136.65]:11904 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726357AbgGIQHM (ORCPT ); Thu, 9 Jul 2020 12:07:12 -0400 IronPort-SDR: cj4VP/hHGP/KAuKfLwurHvyc4FDM/ejuB+UmV/ynnRVs6gp1QHzqrqutHR45ZzNUAhubp/uW8n PEWVUhjkC6pg== X-IronPort-AV: E=McAfee;i="6000,8403,9677"; a="148019961" X-IronPort-AV: E=Sophos;i="5.75,331,1589266800"; d="scan'208";a="148019961" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2020 09:07:10 -0700 IronPort-SDR: yU5zitncKz0vM5sDufqsVRGMPN603OF4gvTaLcUcM+HowzejvgfYaCTeUcfj7oI5UgEW47uaob pHlmD8IrZ20A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,331,1589266800"; d="scan'208";a="484328744" Received: from lkp-server01.sh.intel.com (HELO 5019aad283e6) ([10.239.97.150]) by fmsmga005.fm.intel.com with ESMTP; 09 Jul 2020 09:07:08 -0700 Received: from kbuild by 5019aad283e6 with local (Exim 4.92) (envelope-from ) id 1jtZ4l-000072-Mw; Thu, 09 Jul 2020 16:07:07 +0000 Date: Fri, 10 Jul 2020 00:06:18 +0800 From: kernel test robot To: Antoine Tenart Cc: kbuild-all@lists.01.org, Quentin Schulz , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: phy: mscc: fix ptr_ret.cocci warnings Message-ID: <20200709160618.GA43595@e574ca468740> References: <202007100043.AqyWtI2n%lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202007100043.AqyWtI2n%lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: kernel test robot drivers/net/phy/mscc/mscc_ptp.c:1496:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 7d272e63e097 ("net: phy: mscc: timestamping and PHC support") CC: Antoine Tenart Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: b966b5cf71790478be7726593d011cb085a97a94 commit: 7d272e63e0979d38a6256108adbe462d621c26c5 [2625/6900] net: phy: mscc: timestamping and PHC support mscc_ptp.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/net/phy/mscc/mscc_ptp.c +++ b/drivers/net/phy/mscc/mscc_ptp.c @@ -1493,10 +1493,7 @@ static int __vsc8584_init_ptp(struct phy vsc8531->ptp->ptp_clock = ptp_clock_register(&vsc8531->ptp->caps, &phydev->mdio.dev); - if (IS_ERR(vsc8531->ptp->ptp_clock)) - return PTR_ERR(vsc8531->ptp->ptp_clock); - - return 0; + return PTR_ERR_OR_ZERO(vsc8531->ptp->ptp_clock); } void vsc8584_config_ts_intr(struct phy_device *phydev)