From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C1DAC433E2 for ; Thu, 9 Jul 2020 20:09:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CB1E20720 for ; Thu, 9 Jul 2020 20:09:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726769AbgGIUJx (ORCPT ); Thu, 9 Jul 2020 16:09:53 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:55900 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726262AbgGIUJx (ORCPT ); Thu, 9 Jul 2020 16:09:53 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jtcrd-004NEB-0d; Thu, 09 Jul 2020 22:09:49 +0200 Date: Thu, 9 Jul 2020 22:09:49 +0200 From: Andrew Lunn To: Chris Healy Cc: vivien.didelot@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: Add serdes read/write dynamic debug Message-ID: <20200709200949.GA1037260@lunn.ch> References: <20200709184318.4192-1-cphealy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200709184318.4192-1-cphealy@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jul 09, 2020 at 11:43:18AM -0700, Chris Healy wrote: > Add deb_dbg print statements in both serdes_read and serdes_write > functions. Hi Chris Why is SERDES access special? Why not all accesses? global1, global2, global3, port, etc. As David said, tracepoints are better for this. Take a look at include/trace/events/mdio.h and drivers/net/phy/mdio_bus.c as an example which traces all mdio accesses. Andrew