From: Dominique Martinet <asmadeus@codewreck.org>
To: Christoph Hellwig <hch@lst.de>
Cc: ericvh@gmail.com, lucho@ionkov.net,
v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+e6f77e16ff68b2434a2c@syzkaller.appspotmail.com
Subject: Re: [PATCH] net/9p: validate fds in p9_fd_open
Date: Fri, 10 Jul 2020 13:12:32 +0200 [thread overview]
Message-ID: <20200710111232.GC17924@nautica> (raw)
In-Reply-To: <20200710085722.435850-1-hch@lst.de>
Christoph Hellwig wrote on Fri, Jul 10, 2020:
> p9_fd_open just fgets file descriptors passed in from userspace, but
> doesn't verify that they are valid for read or writing. This gets
> cought down in the VFS when actually attemping a read or write, but a
> new warning added in linux-next upsets syzcaller.
>
> Fix this by just verifying the fds early on.
>
> Reported-by: syzbot+e6f77e16ff68b2434a2c@syzkaller.appspotmail.com
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me, I'll pick it up shortly.
--
Dominique
next prev parent reply other threads:[~2020-07-10 11:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 8:57 [PATCH] net/9p: validate fds in p9_fd_open Christoph Hellwig
2020-07-10 11:12 ` Dominique Martinet [this message]
2020-07-10 22:56 ` Doug Nazar
2020-07-11 10:49 ` Dominique Martinet
2020-07-13 7:38 ` Christoph Hellwig
2020-07-15 7:37 ` Christoph Hellwig
2020-07-15 13:47 ` Dominique Martinet
2020-07-15 18:19 ` Christoph Hellwig
2020-07-15 21:24 ` David Miller
2020-07-16 7:58 ` Dominique Martinet
2020-07-16 20:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710111232.GC17924@nautica \
--to=asmadeus@codewreck.org \
--cc=ericvh@gmail.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=syzbot+e6f77e16ff68b2434a2c@syzkaller.appspotmail.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).